Code review comment for ~paelzer/ubuntu/+source/ipxe:merge-ipxe-groovy-36a4c85-5

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Thanks for -v6, it made the range-diff easier to read and follow. I saw the version revert, and patches coming back, and later being dropped, and I think it's a perfectly valid case for removing the commits, as consolidating the logical is one of the objectives of that step. I understand that it's quite the squashing, and might make a reviewer wonder about what happened. When I do something like that, I usually mention it in detail in the MP. It's just a matter of preference, and I used your -v6 tag for this review.

Continuing...

« Back to merge proposal