Code review comment for ~paelzer/ubuntu/+source/ipxe:merge-ipxe-groovy-36a4c85-5

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Having checked out the merge branch, with all our changes on top of new/debian, I see that the enable-https patch, from this commit (first one on top of new/debian):

commit 2fa82ccd07a6f1360bc357cf1a45490e347c35c0
Author: Christian Ehrhardt <email address hidden>
Date: Thu Aug 17 08:28:19 2017 +0200

    - d/p/enable-https.patch: Enable HTTPS support.

Is being removed in this commit:
commit 50a9def24c715aa5e44800c2068e43511d14238f
Author: Christian Ehrhardt <email address hidden>
Date: Wed Jun 24 13:24:30 2020 +0200

    - d/rules: only enable https on non EFI roms. This lets EFI handle https
      itself and avoids breakage in TPL manipulations (LP: #1882671)

Two things:

a) the 50a9def24c715aa5e44800c2068e43511d14238f commit is not mentioning that the enable-https.patch patch is being removed

b) d/changelog still lists the enable-https.patch patch as being part of the delta:
  * Merge with Debian unstable (LP: #1884758). Remaining changes:
    - d/p/enable-https.patch: Enable HTTPS support.

« Back to merge proposal