Merge ~paelzer/ubuntu/+source/qemu:lp-1830243-secure-boot-toleration-xenial into ubuntu/+source/qemu:ubuntu/xenial-devel

Proposed by Christian Ehrhardt 
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 98ec5a6d0d88e0bca606a86d0a522c246538cf7c
Proposed branch: ~paelzer/ubuntu/+source/qemu:lp-1830243-secure-boot-toleration-xenial
Merge into: ubuntu/+source/qemu:ubuntu/xenial-devel
Diff against target: 122 lines (+100/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu/lp-1830243-s390-bios-Skip-bootmap-signature-entries.patch (+92/-0)
Reviewer Review Type Date Requested Status
Rafael David Tinoco (community) Approve
Canonical Server packageset reviewers Pending
git-ubuntu developers Pending
Review via email: mp+369709@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

PPA: https://launchpad.net/~paelzer/+archive/ubuntu/bug-1830243-secure-boot-toleration

Testign this needs a secure boot enabled s390x kernel which I haven't seen yet.
I asked on the bug who could verify this.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I would like to review this one, since these were already in qemu 4.0 merge. Will get back to this soon.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

I don't have access to s390 yet (working on it) so I'll do a logical review only.

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

without the fix:

(c)inaddy@lqemuxenial:~$ virsh start --console kguesttest
Domain kguesttest started
Connected to domain kguesttest
Escape character is ^]
Using SCSI scheme.
                  ..
                    ! No EXEC entry !

with the fix:

(c)inaddy@lqemuxenial:~$ virsh start --console kguesttest
Domain kguesttest started
Connected to domain kguesttest
Escape character is ^]
.......
       [ 0.501871] Linux version 5.2.0-1-generic (buildd@bos02-s390x-020) (gcc version 8.3.0 (Ubuntu 8.3.0-13ubuntu1)) #2-Ubuntu SMP Tue May 28 15:17:17 UTC 2019 (Ubuntu 5.2.0-1.2-generic 5.2.0-rc2)
[ 0.501873] setup.289988: Linux is running under KVM in 64-bit mode
[ 0.501898] setup.b050d0: The maximum memory size is 4096MB

review: Approve
Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

patch is upstream and straightforward, binary generation is good:

dpkg-deb: building package 'qemu' in '../qemu_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system' in '../qemu-system_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-block-extra' in '../qemu-block-extra_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-common' in '../qemu-system-common_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-misc' in '../qemu-system-misc_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-arm' in '../qemu-system-arm_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-mips' in '../qemu-system-mips_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-sparc' in '../qemu-system-sparc_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-ppc' in '../qemu-system-ppc_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-utils' in '../qemu-utils_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-guest-agent' in '../qemu-guest-agent_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-kvm' in '../qemu-kvm_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-user' in '../qemu-user_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-user-binfmt' in '../qemu-user-binfmt_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-x86' in '../qemu-system-x86_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-user-static' in '../qemu-user-static_2.5+dfsg-5ubuntu10.41_s390x.deb'.
dpkg-deb: building package 'qemu-system-s390x' in '../qemu-system-s390x_2.5+dfsg-5ubuntu10.41_s390x.deb'.

all good o/

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

This is fix released nowadays, cleaning up old MP

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches