Merge ~paelzer/ubuntu/+source/qemu:merge-5.1-4-HIRSUTE into ubuntu/+source/qemu:debian/sid

PPA: https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/4321/+packages

So far this is "drop a lot + carry the rest + usual updates", not much more.
But then testing has only started ... we will see how much happens until we consider this ready.

Never the less I'd appreciate a review on the current state so that we can handle any later changes (which in comparison are small then) much faster.

Almost forgot, I also have pushed tag:5.0-5ubuntu9-logical to help to compare the merge.

Summary:
I started with 85 patches after split, 71 without changelog and finally
64 after squashing
I also marked changes that are expected to drop (in commit message)
and expect 47 to be dropped.

Things work fine so far, I'll now merge libvirt alongside it to test them together.
As mentioned reviewing this already would be awesome.

FYI - the armhf build issue is discussed in bug 1890435 and shall not bother this for now.

I am grabbing this MP for review.

* Changelog:
  - [x] old content and logical tag match as expected
  - [√] changelog entry correct version and targeted codename
  - [√] changelog entries correct
  - [√] update-maintainer has been run

* Actual changes:
  - [√] no upstream changes to consider
  - [√] no further upstream version to consider
  - [√] debian changes look safe

* Old Delta:
  - [√] dropped changes are ok to be dropped
  - [√] nothing else to drop
  - [√] changes forwarded upstream/debian (if appropriate)

* New Delta:
  - [√] no new patches added
  - [-] patches match what was proposed upstream
  - [-] patches correctly included in debian/patches/series
  - [-] patches have correct DEP3 metadata

* Build/Test:
  - [√] build is ok
  - [√] verified PPA package installs/uninstalls
  - [-] autopkgtest against the PPA package passes
  - [√] sanity checks test fine

In short, LGTM, +1.

This is the first time I am reviewing a qemu MP (quite interesting, learned some packaging tricks along the way) so forgive me if I am missing anything.

A good portion of the delta was dropped either because they were applied upstream or Debian, that's great! I have just a single question about one piece of the current delta: the "improved dependencies" changes, were they proposed to Debian at some point? They do not seem strictly related to Ubuntu. If it was (maybe via a bug report? or salsa MP?) a link to it would be good IMHO.

I also think you forgot to push the git-ubuntu tags (those tags in the git repo under your namespace are outdated), however, I was able to follow the changes.

Thanks for your review Lucas.

There are two kinds of dependency deltas.
One set is for packages in universe and that doesn't bother Debian.
The other set - and that is probably the one you asked for - is related to the default installed block backends. That was discussed with Debian but they have a much less Openstack centric use case in mind and therefore didn't want that (maybe 3 years ago).
Unfortunately I haven't found a good bug/link to share. But I'll add a comment to the commit to help reviewers next time.

Tags, well better late than never.
5.0-5ubuntu9-logical (was there)
5.0-5ubuntu9-new-v1
5.0-5ubuntu9-orig
5.0-5ubuntu9-split

Unfortunately due to git-ubutu errors the imports and due to tat to some extend the usual workflow didn't work (and won't until we can handle .git dirs). But I should maybe have used a more common name scheme - my bad.

Thanks for the review.
The tests are still blocked by bug 1902540, but other than that we seem to be ready.

Pushed updates to the merge related to minor uploads that happened while this was in flight (no need to re-review).

After debugging with Doko for weeks, we need to makr armhf to compile with gcc-9 for now due to bug 1890435.

That was done and all tests now passed.

One remaining issue in bug 1904584 that will be tracked separately.

To ssh://git.launchpad.net/~usd-import-team/ubuntu/+source/qemu
 * [new tag] upload/1%5.1+dfsg-4ubuntu1 -> upload/1%5.1+dfsg-4ubuntu1

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading qemu_5.1+dfsg-4ubuntu1.dsc: done.
  Uploading qemu_5.1+dfsg.orig.tar.xz: done.
  Uploading qemu_5.1+dfsg-4ubuntu1.debian.tar.xz: done.
  Uploading qemu_5.1+dfsg-4ubuntu1_source.buildinfo: done.
  Uploading qemu_5.1+dfsg-4ubuntu1_source.changes: done.
Successfully uploaded packages.