Merge lp://qastaging/~paolo-de-rosa/charms/trusty/percona-cluster/innodb_flush_log into lp://qastaging/~openstack-charmers-archive/charms/trusty/percona-cluster/next

charm_lint_check #5704 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11805556/
Build: http://10.245.162.77:8080/job/charm_lint_check/5704/

charm_unit_test #5336 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5336/

charm_amulet_test #4892 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11805574/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4892/

This is fine, there are situations where one doesn't need percona to issue fsync() on innodb redo logs after each commit.

I'd just shorten the description of the option, just explaining what possible options are and then perhaps add URL link that points to percona/mysql documentation.

There is one issue I'd like to see fixed before this merge is approved by me - comments are inline.

charm_lint_check #5728 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11811106/
Build: http://10.245.162.77:8080/job/charm_lint_check/5728/

charm_unit_test #5360 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/5360/

charm_amulet_test #4920 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11811119/
Build: http://10.245.162.77:8080/job/charm_amulet_test/4920/

This now looks fine to me.

charm_lint_check #6632 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11921247/
Build: http://10.245.162.77:8080/job/charm_lint_check/6632/

charm_unit_test #6259 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6259/

charm_amulet_test #5262 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test missing

AMULET Results (max last 2 lines):
INFO:root:Search string not found in makefile target commands.
ERROR:root:No make target was executed.

Full amulet test output: http://paste.ubuntu.com/11921802/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5262/

The percona-cluster/next amulet tests are now known to be passing. Can this proposed branch be rebased to pull in those test updates?

charm_unit_test #6359 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6359/

charm_lint_check #6732 percona-cluster-next for paolo-de-rosa mp263534
    LINT FAIL: lint-test failed
    LINT FAIL: charm-proof failed

LINT Results (max last 2 lines):
make: *** [lint] Error 200
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/11925356/
Build: http://10.245.162.77:8080/job/charm_lint_check/6732/

charm_amulet_test #5274 percona-cluster-next for paolo-de-rosa mp263534
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/11925380/
Build: http://10.245.162.77:8080/job/charm_amulet_test/5274/

Please take note of the failed charm proof (lint) test re: innodb-flush-log-at-trx-commit, which appears to also be causing the amulet test to fail. Thanks!

charm_unit_test #6412 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/6412/

charm_lint_check #6885 percona-cluster-next for paolo-de-rosa mp263534
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/6885/

charm_amulet_test #5327 percona-cluster-next for paolo-de-rosa mp263534
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/5327/

Paolo, I have a nit with the config description and would like to see that flushed out a bit more. There's a lot more information on the setting itself upstream which isn't included here. I don't think we should include it here specifically but instead should possibly reference the upstream documentation in addition to a basic discussion.

charm_lint_check #9229 percona-cluster-next for paolo-de-rosa mp263534
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/9229/

charm_unit_test #8530 percona-cluster-next for paolo-de-rosa mp263534
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/8530/

charm_amulet_test #6191 percona-cluster-next for paolo-de-rosa mp263534
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6191/

Hi Paola

Currently showing a merge conflict - please could you rebase and then I think this is good to be landed once OSCI has re-tested.