Merge ~pappacena/launchpad:mp-refs-privacy-change into launchpad:master
Proposed by
Thiago F. Pappacena
| Status: | Needs review |
|---|---|
| Proposed branch: | ~pappacena/launchpad:mp-refs-privacy-change |
| Merge into: | launchpad:master |
| Prerequisite: | ~pappacena/launchpad:create-mp-refs |
| Diff against target: |
582 lines (+309/-16) 10 files modified
lib/lp/code/configure.zcml (+9/-0) lib/lp/code/interfaces/gitjob.py (+16/-1) lib/lp/code/model/branchmergeproposal.py (+9/-7) lib/lp/code/model/gitjob.py (+63/-1) lib/lp/code/model/gitrepository.py (+11/-1) lib/lp/code/model/tests/test_branchmergeproposal.py (+4/-4) lib/lp/code/model/tests/test_gitjob.py (+127/-1) lib/lp/code/model/tests/test_gitrepository.py (+62/-0) lib/lp/services/config/schema-lazr.conf (+4/-0) lib/lp/testing/fakemethod.py (+4/-1) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Needs Information | ||
|
Review via email:
|
|||
Commit message
Background job to add/remove merge proposal's virtual refs when a repository has its privacy changed
To post a comment you must log in.
Revision history for this message
| Thiago F. Pappacena (pappacena) wrote | # |
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
There's an unfortunate complication around private-to-public transitions that I fear is going to require quite a bit more work to get right (assuming I haven't got the wrong end of the stick somewhere). Details below.