Launchpad itself

Merge ~pappacena/launchpad:snap-pillar-subscribe-removal-job into launchpad:master

  1. Git
  2. lp:~pappacena/launchpad
  3. snap-pillar-subscribe-removal-job
  4. Merge into master
Proposed by Thiago F. Pappacena
Status: Superseded
Proposed branch: ~pappacena/launchpad:snap-pillar-subscribe-removal-job
Merge into: launchpad:master
Prerequisite: ~pappacena/launchpad:snap-pillar-subscribe
Diff against target: 890 lines (+199/-85)
16 files modified
database/schema/security.cfg (+2/-0)
lib/lp/blueprints/model/specification.py (+2/-2)
lib/lp/blueprints/tests/test_specification.py (+4/-4)
lib/lp/bugs/model/bug.py (+3/-3)
lib/lp/code/browser/branchsubscription.py (+2/-2)
lib/lp/code/browser/gitsubscription.py (+2/-2)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/gitrepository.py (+1/-1)
lib/lp/code/model/tests/test_branchsubscription.py (+3/-3)
lib/lp/registry/model/sharingjob.py (+36/-1)
lib/lp/registry/services/sharingservice.py (+15/-12)
lib/lp/registry/services/tests/test_sharingservice.py (+11/-7)
lib/lp/registry/tests/test_sharingjob.py (+56/-10)
lib/lp/snappy/interfaces/snap.py (+4/-0)
lib/lp/snappy/model/snap.py (+36/-12)
lib/lp/snappy/tests/test_snap.py (+20/-24)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+398318@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2021-03-11.

Commit message

Remove dangling SnapSubscription when changing Snap pillar's sharing policy

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) :
Revision history for this message
Colin Watson (cjwatson) :
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

Pushed the requested changes, and added a comment about `get_snap_privacy_filter` method.

Revision history for this message
Colin Watson (cjwatson) :
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

Pushed the changes for admin visibility after talking to wgrant and cjwatson.

Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Thiago F. Pappacena (pappacena) :

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.