Merge ~paride/utah:forward-file-lists into utah:master

Proposed by Paride Legovini
Status: Merged
Merged at revision: dc2237e1778f9f0f85f0c8886f303fa47f853435
Proposed branch: ~paride/utah:forward-file-lists
Merge into: utah:master
Diff against target: 202 lines (+86/-23)
5 files modified
utah/isotest/data/file_list_subiquity.groovy (+21/-0)
utah/isotest/data/file_list_ubiquity (+1/-0)
utah/isotest/data/file_list_ubiquity.groovy (+18/-0)
utah/isotest/data/file_list_uefi.groovy (+3/-0)
utah/isotest/iso_static_validation.py (+43/-23)
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Paride Legovini Needs Fixing
Review via email: mp+393451@code.qastaging.launchpad.net

Commit message

Make release-specific file lists apply to future releases

Static validation file lists specific for a given release are allowed
in the form of files named with the scheme:

  file_list.<release>

This change makes these lists apply for <release> and for all the
releases that follow <release>, unless a newer release-specific file
exists, in which case that's the one that applies.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

The idea seems fine but I think there's a logic bug hiding.

review: Needs Fixing
Revision history for this message
Paride Legovini (paride) :
review: Needs Fixing
Revision history for this message
Paride Legovini (paride) wrote :

MP updated with fixed logic and helper function.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

LGTM but i'm mostly asleep :)

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches