UTAH

Merge ~paride/utah:udi-static-validation into utah:master

  1. Git
  2. lp:~paride/utah
  3. udi-static-validation
  4. Merge into master
Proposed by Paride Legovini
Status: Merged
Merged at revision: 554ae5542f91277ea52cc6fe08ceb17ec1595df7
Proposed branch: ~paride/utah:udi-static-validation
Merge into: utah:master
Diff against target: 170 lines (+64/-11)
4 files modified
tests/test_run_utah_tests.py (+1/-1)
utah/iso.py (+6/-1)
utah/isotest/data/file_list_udi (+18/-0)
utah/isotest/iso_static_validation.py (+39/-9)
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Heather Ellsworth Pending
UTAH Dev Pending
Review via email: mp+437355@code.qastaging.launchpad.net

Commit message

Update the ISO tests for the UDI desktop installer

Partially based on:

https://code.launchpad.net/~seb128/utah/+git/utah/+merge/436867

Thanks: Sebastien Bacher, Heather Ellsworth.

To post a comment you must log in.
Revision history for this message
Paride Legovini (paride) wrote (last edit ):

Tested with:

# 1. good old ubiquity

$ sudo -u utah -i /usr/share/utah/isotest/iso_static_validation.py --name /path/to/jammy-desktop-amd64.iso

# 2. legacy ubiquity

$ sudo -u utah -i /usr/share/utah/isotest/iso_static_validation.py --name /path/to/lunar-desktop-legacy-amd64.iso

# 3. UDI image

$ sudo -u utah -i /usr/share/utah/isotest/iso_static_validation.py --name /path/to/lunar-desktop-amd64.iso

If you test this remember that the images have to up-to-date, otherwise the checksum and serial checks will fail.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for picking that up!

the python 3.11 commit doesn't seem related to the static iso tests but it's a different commit so that should be ok right?

the code changes seem fine to me

review: Approve
Revision history for this message
Paride Legovini (paride) wrote :

Thanks for reviewing! As you say the Python3.11 fix is unrelated, I'll do a fast-forward merge so they'll not be related in git commit history.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches