Merge lp://qastaging/~parthm/bzr/242522-symlink-repo-to-usb-stick into lp://qastaging/bzr

Proposed by Parth Malwankar
Status: Work in progress
Proposed branch: lp://qastaging/~parthm/bzr/242522-symlink-repo-to-usb-stick
Merge into: lp://qastaging/bzr
Diff against target: 65 lines (+33/-1)
3 files modified
bzrlib/tests/test_transform.py (+21/-0)
bzrlib/transform.py (+7/-1)
doc/en/release-notes/bzr-2.6.txt (+5/-0)
To merge this branch: bzr merge lp://qastaging/~parthm/bzr/242522-symlink-repo-to-usb-stick
Reviewer Review Type Date Requested Status
bzr-core Pending
Review via email: mp+94679@code.qastaging.launchpad.net

Description of the change

This patch updates updates transform.create_symlink to issue a warning in case the target filesystem (e.g. fat mounted on Linux) does not support symlinks. It catches OSError EPERM and issues a warning to the user. The branch is created / updated but the symlink is not created.

This patch along with https://code.launchpad.net/~parthm/bzr/81689-win-symlink-warning/+merge/93784 allow bzr to work with repos containing symlinks on file systems that don't allow symlinks by ignoring symlinks (i.e. not creating them at all).

To post a comment you must log in.
Revision history for this message
Parth Malwankar (parthm) wrote :

Marking as in-progress at the moment. Will resubmit along with 81689 patch to ensure that both patches have consistent behavior and messages.

Unmerged revisions

6478. By Parth Malwankar

updated release notes

6477. By Parth Malwankar

added test

6476. By Parth Malwankar

symlink skipped if target filesystem does not support symlinks

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.