Merge lp://qastaging/~pat-mcgowan/messaging-app/revert-counts into lp://qastaging/messaging-app
Proposed by
Pat McGowan
| Status: | Merged |
|---|---|
| Approved by: | Bill Filler |
| Approved revision: | 593 |
| Merged at revision: | 593 |
| Proposed branch: | lp://qastaging/~pat-mcgowan/messaging-app/revert-counts |
| Merge into: | lp://qastaging/messaging-app |
| Diff against target: |
41 lines (+7/-5) 2 files modified
src/qml/ComposeBar.qml (+3/-1) src/qml/SettingsPage.qml (+4/-4) |
| To merge this branch: | bzr merge lp://qastaging/~pat-mcgowan/messaging-app/revert-counts |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Tiago Salem Herrmann (community) | Approve | ||
| Ubuntu Phablet Team | Pending | ||
|
Review via email:
|
|||
Commit message
The character count logic is much more complex and needs to account for escape characters and different encoding schemes that change the counts.
For now this hides the elements that were added. Anyone who turned it on will no longer see them.
Description of the change
The character count logic is much more complex and needs to account for escape characters and different encoding schemes that change the counts.
For now this hides the elements that were added. Anyone who turned it on will no longer see them.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
code looks good.
thank you.