Merge lp://qastaging/~pat-mcgowan/ubuntu-system-settings/other-vibrations into lp://qastaging/ubuntu-system-settings
Status: | Superseded | ||||||||
---|---|---|---|---|---|---|---|---|---|
Proposed branch: | lp://qastaging/~pat-mcgowan/ubuntu-system-settings/other-vibrations | ||||||||
Merge into: | lp://qastaging/ubuntu-system-settings | ||||||||
Diff against target: |
171 lines (+37/-19) 5 files modified
debian/control (+4/-4) debian/rules (+4/-0) plugins/sound/PageComponent.qml (+6/-0) plugins/sound/sound.cpp (+21/-14) plugins/sound/sound.h (+2/-1) |
||||||||
To merge this branch: | bzr merge lp://qastaging/~pat-mcgowan/ubuntu-system-settings/other-vibrations | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
system-apps-ci-bot | continuous-integration | Needs Fixing | |
Jonas G. Drange (community) | Approve | ||
Review via email:
|
This proposal has been superseded by a proposal from 2016-08-23.
Commit message
* allows uss to be built by crossbuilder
* adds dbus interface to communicate with usensord
* hides ringer slider when there's no modem
Description of the change
This branch has three changes
It fixes the debian files to work with crossbuilder
It adds a dbus interface to communicate with usensord to get and set the other-vibrate property (lp:1433590)
It adds a missing connection for NetworkingStatus and does not show the ringer slider when there is no modem (lp:1614637)
The corresponding usensord support is in https:/
See https:/
LGTM, thanks. Also, let's wait for ci to run before top-approving?