Merge lp://qastaging/~patrick-crews/drizzle-automation/alter_sysbench_rpt into lp://qastaging/drizzle-automation
Proposed by
Patrick Crews
| Status: | Merged |
|---|---|
| Merged at revision: | 146 |
| Proposed branch: | lp://qastaging/~patrick-crews/drizzle-automation/alter_sysbench_rpt |
| Merge into: | lp://qastaging/drizzle-automation |
| Diff against target: |
84 lines (+32/-10) 1 file modified
drizzle/automation/reports/sysbench.py (+32/-10) |
| To merge this branch: | bzr merge lp://qastaging/~patrick-crews/drizzle-automation/alter_sysbench_rpt |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Monty Taylor | Approve | ||
|
Review via email:
|
|||
Description of the change
Altered the sysbench reporting module so that it will do comparisons against the staging branches historical sysbench data if the branch under test wasn't the staging branch.
This is because such branches rarely have enough historical data to produce interesting reports.
One possible TODO would be to add a check to see if we have enough records for the branch (currently at least 20) and to skip my changes, but that is open for debate : )
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks good to me.
A next step might be to add a configuration option to allow for specification of what the staging_branch for a given branch is (in case this were to be applied outside of our environment... you might want to be able to configure a different branch to compare against.
HOWEVER - I would not wait to get that done before rolling this out, because this will have a significant positive impact on our ability to work day to day.