Drizzle

Merge lp://qastaging/~patrick-crews/drizzle/mysql-migrate-tests into lp://qastaging/drizzle/7.0

mysql-migrate-tests
Merge into 7.0

Proposed by Patrick Crews on 2011-03-12

Status:

Merged

Approved by:

Brian Aker on 2011-03-12

Approved revision:

2050

Merged at revision:

2232

Proposed branch:

lp://qastaging/~patrick-crews/drizzle/mysql-migrate-tests

Merge into:

lp://qastaging/drizzle/7.0

Diff against target:

4505 lines (+4052/-0)

90 files modified

tests/std_data/mysqlmigrate_basic.dat (+3/-0)
tests/std_data/mysqlmigrate_binary_type.dat (+14/-0)
tests/std_data/mysqlmigrate_bit_type.dat (+18/-0)
tests/std_data/mysqlmigrate_blob_type.dat (+41/-0)
tests/std_data/mysqlmigrate_char_type.dat (+14/-0)
tests/std_data/mysqlmigrate_comments.dat (+10/-0)
tests/std_data/mysqlmigrate_databases.dat (+10/-0)
tests/std_data/mysqlmigrate_date_type.dat (+14/-0)
tests/std_data/mysqlmigrate_datetime_type.dat (+14/-0)
tests/std_data/mysqlmigrate_decimal_type.dat (+18/-0)
tests/std_data/mysqlmigrate_double_type.dat (+14/-0)
tests/std_data/mysqlmigrate_engines.dat (+6/-0)
tests/std_data/mysqlmigrate_enum_type.dat (+15/-0)
tests/std_data/mysqlmigrate_float_type.dat (+21/-0)
tests/std_data/mysqlmigrate_foreign_key.dat (+4/-0)
tests/std_data/mysqlmigrate_indexes.dat (+3/-0)
tests/std_data/mysqlmigrate_integer_type.dat (+67/-0)
tests/std_data/mysqlmigrate_large_data.dat (+230/-0)
tests/std_data/mysqlmigrate_numeric_type.dat (+18/-0)
tests/std_data/mysqlmigrate_partitions.dat (+2/-0)
tests/std_data/mysqlmigrate_real_type.dat (+18/-0)
tests/std_data/mysqlmigrate_set_type.dat (+15/-0)
tests/std_data/mysqlmigrate_text_type.dat (+41/-0)
tests/std_data/mysqlmigrate_time_type.dat (+16/-0)
tests/std_data/mysqlmigrate_timestamp_type.dat (+12/-0)
tests/std_data/mysqlmigrate_varbinary_type.dat (+14/-0)
tests/std_data/mysqlmigrate_varchar_type.dat (+14/-0)
tests/std_data/mysqlmigrate_year_type.dat (+18/-0)
tests/suite/mysql_migrate/README (+7/-0)
tests/suite/mysql_migrate/include/drizzledump_migrate.inc (+45/-0)
tests/suite/mysql_migrate/include/mysql_cleanup.inc (+4/-0)
tests/suite/mysql_migrate/r/all_databases.result (+84/-0)
tests/suite/mysql_migrate/r/basic.result (+20/-0)
tests/suite/mysql_migrate/r/binary_type.result (+26/-0)
tests/suite/mysql_migrate/r/bit_type.result (+29/-0)
tests/suite/mysql_migrate/r/blob_type.result (+67/-0)
tests/suite/mysql_migrate/r/char_type.result (+25/-0)
tests/suite/mysql_migrate/r/comments.result (+33/-0)
tests/suite/mysql_migrate/r/databases.result (+70/-0)
tests/suite/mysql_migrate/r/date_type.result (+25/-0)
tests/suite/mysql_migrate/r/datetime_type.result (+25/-0)
tests/suite/mysql_migrate/r/decimal_type.result (+27/-0)
tests/suite/mysql_migrate/r/destination-database.result (+35/-0)
tests/suite/mysql_migrate/r/engines.result (+29/-0)
tests/suite/mysql_migrate/r/enum_type.result (+26/-0)
tests/suite/mysql_migrate/r/float_type.result (+30/-0)
tests/suite/mysql_migrate/r/foreign_key.result (+28/-0)
tests/suite/mysql_migrate/r/indexes.result (+29/-0)
tests/suite/mysql_migrate/r/integer_type.result (+103/-0)
tests/suite/mysql_migrate/r/large_data.result (+1601/-0)
tests/suite/mysql_migrate/r/numeric_type.result (+27/-0)
tests/suite/mysql_migrate/r/partitions.result (+21/-0)
tests/suite/mysql_migrate/r/real_type.result (+27/-0)
tests/suite/mysql_migrate/r/set_type.result (+27/-0)
tests/suite/mysql_migrate/r/text_type.result (+67/-0)
tests/suite/mysql_migrate/r/time_type.result (+27/-0)
tests/suite/mysql_migrate/r/timestamp_type.result (+23/-0)
tests/suite/mysql_migrate/r/varchar_type.result (+25/-0)
tests/suite/mysql_migrate/r/year_type.result (+30/-0)
tests/suite/mysql_migrate/t/all_databases.test (+90/-0)
tests/suite/mysql_migrate/t/basic.test (+16/-0)
tests/suite/mysql_migrate/t/binary_type.test (+16/-0)
tests/suite/mysql_migrate/t/bit_type.test (+16/-0)
tests/suite/mysql_migrate/t/blob_type.test (+31/-0)
tests/suite/mysql_migrate/t/char_type.test (+16/-0)
tests/suite/mysql_migrate/t/comments.test (+18/-0)
tests/suite/mysql_migrate/t/databases.test (+78/-0)
tests/suite/mysql_migrate/t/date_type.test (+16/-0)
tests/suite/mysql_migrate/t/datetime_type.test (+16/-0)
tests/suite/mysql_migrate/t/decimal_type.test (+16/-0)
tests/suite/mysql_migrate/t/destination-database.test (+56/-0)
tests/suite/mysql_migrate/t/double_type.test (+16/-0)
tests/suite/mysql_migrate/t/engines.test (+21/-0)
tests/suite/mysql_migrate/t/enum_type.test (+16/-0)
tests/suite/mysql_migrate/t/float_type.test (+16/-0)
tests/suite/mysql_migrate/t/foreign_key.test (+17/-0)
tests/suite/mysql_migrate/t/indexes.test (+17/-0)
tests/suite/mysql_migrate/t/integer_type.test (+36/-0)
tests/suite/mysql_migrate/t/large_data.test (+26/-0)
tests/suite/mysql_migrate/t/master.opt (+1/-0)
tests/suite/mysql_migrate/t/numeric_type.test (+16/-0)
tests/suite/mysql_migrate/t/partitions.test (+16/-0)
tests/suite/mysql_migrate/t/real_type.test (+16/-0)
tests/suite/mysql_migrate/t/set_type.test (+16/-0)
tests/suite/mysql_migrate/t/text_type.test (+31/-0)
tests/suite/mysql_migrate/t/time_type.test (+16/-0)
tests/suite/mysql_migrate/t/timestamp_type.test (+16/-0)
tests/suite/mysql_migrate/t/varbinary_type.test (+16/-0)
tests/suite/mysql_migrate/t/varchar_type.test (+16/-0)
tests/suite/mysql_migrate/t/year_type.test (+16/-0)

To merge this branch:

bzr merge lp://qastaging/~patrick-crews/drizzle/mysql-migrate-tests

Related bugs:

Bug #683917: Drizzledump fails when trying to migrate MEMORY tables from MySQL	High	Fix Released
Bug #683931: Drizzledump not preserving column comments during migration from MySQL	Medium	Fix Released
Bug #683940: Drizzledump not preserving FOREIGN KEY information during migration from MySQL	Medium	Fix Released
Bug #684277: Drizzledump not preserving INDEX order information when migrating from MySQL	Undecided	Invalid
Bug #684986: Drizzledump migration does not appear to handle BIT datatype gracefully	High	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Drizzle Developers		2011-03-12	Pending
Review via email: mp+53110@code.qastaging.launchpad.net

Description of the change

added suite/mysql-migrate - the tests of drizzledump's mysql-migration capabilities

I believe a small number of tests still need to be re-recorded, but these are skipped by make-test / would be a specialty job imho.

Wanted to get them in the tree once I realized they weren't yet. Instructions and whatnot included (need a mysql server for validation).

Revision history for this message

Patrick Crews (patrick-crews) wrote on 2011-03-12:

NOTE: will likely need to re-record all tests as the mysql port used was a test version...more likely to use an installed / standard version.

On that note, will be adding --validation-server=<> option to dbqp soon. It will serve all kinds of interesting purposes to be able to compare how drizzle does things vs. how mysql does them in lots of scenarios (randgen / ad hoc)...but I digress.