Ubuntu
ubuntu-docs package

Merge lp://qastaging/~paulbrianstewart/ubuntu/oneiric/ubuntu-docs/859165-Help-File-Correction into lp://qastaging/ubuntu/oneiric/ubuntu-docs

  1. Oneiric (11.10)
  2. 859165-Help-File-Correction
  3. Merge into oneiric
Proposed by Paul Stewart
Status: Work in progress
Proposed branch: lp://qastaging/~paulbrianstewart/ubuntu/oneiric/ubuntu-docs/859165-Help-File-Correction
Merge into: lp://qastaging/ubuntu/oneiric/ubuntu-docs
Diff against target: 12 lines (+1/-1)
1 file modified
ubuntu-help/ubuntu-help.pot (+1/-1)
To merge this branch: bzr merge lp://qastaging/~paulbrianstewart/ubuntu/oneiric/ubuntu-docs/859165-Help-File-Correction
Reviewer Review Type Date Requested Status
Michael Terry Disapprove
Ubuntu branches Pending
Review via email: mp+76919@code.qastaging.launchpad.net

Commit message

* Changed the wording of the text from "If this looks correct, click <gui>Close</gui>" to "If this looks correct close the window." This change is because there is no "Close" button on the window.

Description of the change

* Changed the wording of the text from "If this looks correct, click <gui>Close</gui>" to "If this looks correct close the window." This change is because there is no "Close" button on the window.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Awesome catch and thanks, Paul!

But I'm going to disapprove this, because the change should be made upstream. I've filed a new merge request upstream with this same patch. See https://code.launchpad.net/~mterry/ubuntu-docs/display-close/+merge/76986

review: Disapprove
Reply
Revision history for this message
Paul Stewart (paulbrianstewart) wrote :

> Awesome catch and thanks, Paul!
>
> But I'm going to disapprove this, because the change should be made upstream.
> I've filed a new merge request upstream with this same patch. See
> https://code.launchpad.net/~mterry/ubuntu-docs/display-close/+merge/76986

You're welcome Michael, but I can't claim credit for it, that should go to Jiri Gronross (https://launchpad.net/~jiri-gronroos) for the bug report...I just wrote the patch.

Thanks
Paul

Reply

Unmerged revisions

102. By Paul Stewart

* Changed the wording of the text from "If this looks correct, click <gui>Close</gui>" to "If this looks correct close the window." This change is because there is no "Close" button on the window.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: