Merge lp://qastaging/~paulgear/charm-helpers/enable-disable-service-systemd into lp://qastaging/charm-helpers

Proposed by Paul Gear
Status: Merged
Merged at revision: 745
Proposed branch: lp://qastaging/~paulgear/charm-helpers/enable-disable-service-systemd
Merge into: lp://qastaging/charm-helpers
Diff against target: 19 lines (+2/-0)
1 file modified
charmhelpers/core/host.py (+2/-0)
To merge this branch: bzr merge lp://qastaging/~paulgear/charm-helpers/enable-disable-service-systemd
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
charmers Pending
Review via email: mp+324361@code.qastaging.launchpad.net

Description of the change

See lp:1692178 for background on this. This is a fairly simplistic solution, but the mask/unmask has been left in place, in order not to break anything which relies on masked behaviour from systemd-controlled services. I suspect there are no charms which do this, but have no way to be sure; so this is the safe solution which makes enabling services work.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

How does this address lp:1692178 ? My understanding is that the disable/enable will not have any effect and with the mask still in place pause/resume will still fail.

review: Needs Information
Revision history for this message
Stuart Bishop (stub) wrote :

The unmask of course is happening before the enable, so this is fine. While the disable + mask may be redundant, the unmask + enable is not for the case where a service is disabled but not masked.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches