Mir

Merge lp://qastaging/~peat-new/mir/use-hwc-blanking-control-with-hwc10 into lp://qastaging/mir

Proposed by Ratchanan Srirattanamet
Status: Merged
Merged at revision: 3661
Proposed branch: lp://qastaging/~peat-new/mir/use-hwc-blanking-control-with-hwc10
Merge into: lp://qastaging/mir
Diff against target: 132 lines (+48/-5)
4 files modified
src/platforms/android/server/hal_component_factory.cpp (+4/-1)
src/platforms/android/server/hwc_blanking_control.cpp (+11/-2)
src/platforms/android/server/hwc_configuration.h (+2/-1)
tests/unit-tests/platforms/android/server/test_output_builder.cpp (+31/-1)
To merge this branch: bzr merge lp://qastaging/~peat-new/mir/use-hwc-blanking-control-with-hwc10
Reviewer Review Type Date Requested Status
Kevin DuBois (community) Approve
Alan Griffiths Approve
Daniel van Vugt Approve
Review via email: mp+303325@code.qastaging.launchpad.net

Description of the change

android: create HwcBlankingControl as HWC configuration on HWC 1.0

This changes screen initialization on a device using HWC 1.0 from the FB HAL way to the HWC way. This makes vsync works, as previously vsync is not enabled in FbControl.

This fix, together with the hack from lp:~peat-new/mir/hack-eglswapbuffer-call-fbpost , makes graphics with HWComposer works on Samsung Galaxy Tab 2 7.0. So, to properly support this device, the hack must be verified if it's the correct way to do. This is beyond my knowledge and requires a developer to have a look at it.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sounds reasonable and Jenkins is happy too:
https://code.launchpad.net/~mir-team/mir/use-hwc-blanking-control-with-hwc10/+merge/303359

Now just waiting for kdub I guess.

review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

LGTM, but I think paranoia dictates that we autoland from a branch controlled by a team member.

review: Approve
Revision history for this message
Kevin DuBois (kdub) wrote :

iirc, - if (force_backup_display || hwc_version == mga::HwcVersion::hwc10) was for the Galaxy Nexus, but that's not really a supported device anymore.

The only 'supported' device that uses hwc 1.0 is the goldfish emulator used in the Ubuntu SDK. We'll have to check that in the test plan for whatever release this goes out with. lgtm otherwsie.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK then, per Alan's comment please put your approvals here:
https://code.launchpad.net/~mir-team/mir/use-hwc-blanking-control-with-hwc10/+merge/303359

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Forget it. CI is broken in multiple new ways almost every day.

I've had enough and will land some things by hand. Just like the good old days...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches