Ubuntu
sessioninstaller package

Merge lp://qastaging/~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396 into lp://qastaging/ubuntu/maverick/sessioninstaller

  1. Maverick (10.10)
  2. newfix-for-793396
  3. Merge into maverick
Proposed by Peco
Status: Needs review
Proposed branch: lp://qastaging/~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396
Merge into: lp://qastaging/ubuntu/maverick/sessioninstaller
Diff against target: 47 lines (+17/-2)
3 files modified
README (+1/-1)
debian/changelog (+15/-0)
session-installer (+1/-1)
To merge this branch: bzr merge lp://qastaging/~peco/ubuntu/maverick/sessioninstaller/newfix-for-793396
Reviewer Review Type Date Requested Status
Luke Yelavich (community) Needs Fixing
Review via email: mp+66556@code.qastaging.launchpad.net

Description of the change

Two typos (session-installer and README file).
See diff file attached to the LP: #793396

To post a comment you must log in.
Revision history for this message
Peco (peco) wrote :

The bug LP # 793396 is related to two typos.
I fixed first the one described on the formal description of the bug (fix-for-793396) and then the second typo at the README file (new-fix-for-793396)

Reply
Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks for your work. It appears your branch has 2 changelog entries. Could you plesae merge the entries into 1? Please also target the fix to maverick-proposed, should you feel its worthwhile pushing a fix to maverick updates.

I'd also advise the version to be 0.20+bzr115-0ubuntu1.1, as this makes sure the version doesn't conflict with any later package versions of sessioninstaller in other Ubuntu releases.

Thanks again.

review: Needs Fixing
Reply
Revision history for this message
Peco (peco) wrote :

Sorry for the mistakes. This is my first time and I'm using these easy fixes in order to learn.
I redid the whole process: download the sources (bzr), fix them, doc (dch -i) and commit (locally, debcommit).

But now I've two doubts:

1) How can I target maverick-proposed?.

Instead of:
bzr push lp:~peco/ubuntu/maverick/sessioninstaller/fix-for-793396
I should do:
bzr push lp:~peco/ubuntu/maverick-proposed/sessioninstaller/fix-for-793396

2) How can I set the version to 0.20+bzr115-0ubuntu1.1?
Last time it was automatically defined by bzr

Thanks in advance!

Reply

Unmerged revisions

8. By Peco

Minor typo at README file: "GStreamer codecs" instead of
"GSreamer codecs". (LP: #793396, see diff file)

7. By Peco

A minor typo in the description of the package, as it said
"APT based installer using PackgeKit's session DBus API".
The missing 'a' from PackageKit's was added. (LP: #793396)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: