Percona Server moved to https://jira.percona.com/projects/PS

lp://qastaging/~percona-core/percona-server/5.6-553-bug-1351148

Created by Vlad Lesin on 2014-08-01 and last modified on 2014-09-29

Get this branch:: bzr branch lp://qastaging/~percona-core/percona-server/5.6-553-bug-1351148

Members of Percona core can upload to this branch. Log in for directions.

Branch merges

No branches dependent on this one.

On hold for merging into lp://qastaging/percona-server/5.6

Percona core: Pending requested 2014-08-01

High

Fix Released

Link a bug report

Related blueprints

Branch information

Owner:: Percona core

Project:: Percona Server moved to https://jira.percona.com/projects/PS

Status:: Development

Recent revisions

554. By Vlad Lesin on 2014-09-29

Bug #1351128 fix.

The bug's summary:

1) The value in pins->stack_ends_here is actually incorrect. This value is
calculated when the thread is initialized in my_thread_init(). The problem is
that the value doesn't take into account existing stack usage and just adds the
thread stack size to calculate the beginning of the stack.

2) _lf_pinbox_real_free() is using alloca() in a very unsafe way. alloca()
should only be used by leaf functions, since you cannot predict the amount of
stack space that non-leaf functions will use. As pins->stack_ends_here is
calculated in wrong way and there is no window for the qsort() which is invoked
from _lf_pinbox_real_free() after alloca(), stack overflow can take place.

The solution:

1) Take into accout the current stack offset when stack size is calculated
in my_thread_init();

2) Don't allocate the whole free stack space in _lf_pinbox_real_free(),
take some window for qsort();

553. By Laurynas Biveinis on 2014-03-04

Automerge lp:~laurynas-biveinis/percona-server/bug1287098

552. By Jenkins Master <email address hidden> on 2014-03-04

Merge lp:~hrvojem/percona-server/rn-5.6.16-64.0-tokudb-5.6
http://jenkins.percona.com/job/merge-PS-5.6-docs-kickoff/39/