camera-app

Merge lp://qastaging/~pete-woods/camera-app/handle-quit-signal into lp://qastaging/camera-app

  1. handle-quit-signal
  2. Merge into trunk
Proposed by Pete Woods
Status: Merged
Merged at revision: 257
Proposed branch: lp://qastaging/~pete-woods/camera-app/handle-quit-signal
Merge into: lp://qastaging/camera-app
Diff against target: 45 lines (+7/-3)
2 files modified
camera-app.qml (+5/-1)
debian/control (+2/-2)
To merge this branch: bzr merge lp://qastaging/~pete-woods/camera-app/handle-quit-signal
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher Approve
Dimitri John Ledkov (community) Approve
Antti Kaijanmäki (community) Abstain
Review via email: mp+205546@code.qastaging.launchpad.net

Commit message

Handle the HUD quit signal

This change is only necessary for apps that don't use the UITK MainView

Description of the change

> Are there any related MPs required for this MP to build/function as expected?
No

> Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

> Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Obvs

> Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?
Yes

> If you changed the UI, was the change specified/approved by design?
No change

> If you changed the packaging (debian), did you subscribe a core-dev to this MP?
Subscribing.

Check List:
https://wiki.ubuntu.com/Process/Merges/Checklists/system-apps

Test Plan:
https://wiki.ubuntu.com/Process/Merges/TestPlan/camera-app

Silo:
<missing>

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:230
http://jenkins.qa.ubuntu.com/job/camera-app-ci/159/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/17
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/17/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-i386-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3061
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2780/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2689
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3063
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3063/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2781
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2781/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5196/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3793

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/159/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

Checklist missing.

review: Needs Fixing
Revision history for this message
Pete Woods (pete-woods) wrote :

Adding seb128 to check my packaging changes.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:245
http://jenkins.qa.ubuntu.com/job/camera-app-ci/165/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-i386-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3242
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2913
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2850
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3244
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3244/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2915
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2915/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5319
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3959

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/165/rebuild

review: Approve (continuous-integration)
lp://qastaging/~pete-woods/camera-app/handle-quit-signal updated
244. By Bill Filler

initial support for DESKTOP_MODE

245. By PS Jenkins bot

Releasing 2.9.1+14.04.20140213-0ubuntu1

246. By Bill Filler

skip integration test until it's reworked to be more reliable

247. By PS Jenkins bot

Releasing 2.9.1+14.04.20140214-0ubuntu1

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

waiting for a silo to be linked.

review: Abstain
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

The code itself looks good to me.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) :
review: Abstain
lp://qastaging/~pete-woods/camera-app/handle-quit-signal updated
248. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

claiming core-dev review. All is good.

review: Approve
Revision history for this message
Pete Woods (pete-woods) wrote :

Thanks, Dimitri :)

Revision history for this message
Sebastien Bacher (seb128) wrote :

(sorry, I somewhat didn't see the email about that one, just crossed it while looking at my +activereviews list)

review: Approve
lp://qastaging/~pete-woods/camera-app/handle-quit-signal updated
249. By Bill Filler

click support

250. By PS Jenkins bot

Releasing 2.9.1+14.04.20140306-0ubuntu1

251. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Revision history for this message
Pete Woods (pete-woods) wrote :

No worries, I understand you guys get _lot_ of email!

lp://qastaging/~pete-woods/camera-app/handle-quit-signal updated
252. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

254. By Pete Woods

Update control file with new version constraints

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:254
http://jenkins.qa.ubuntu.com/job/camera-app-ci/170/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-amd64-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/28
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-armhf-ci/28/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-trusty-i386-ci/28
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3845
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3430
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3373
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3869
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3869/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3432
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3432/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5790
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4706

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/170/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches