Network Menu

Merge lp://qastaging/~pete-woods/indicator-network/add-ethernet-settings-export into lp://qastaging/indicator-network

  1. add-ethernet-settings-export
  2. Merge into trunk
Proposed by Pete Woods
Status: Approved
Approved by: dobey
Approved revision: 672
Proposed branch: lp://qastaging/~pete-woods/indicator-network/add-ethernet-settings-export
Merge into: lp://qastaging/indicator-network
Prerequisite: lp://qastaging/~pete-woods/indicator-network/clean-up-menu-exports
Diff against target: 389 lines (+101/-29)
14 files modified
src/indicator/factory.cpp (+6/-1)
src/indicator/factory.h (+2/-0)
src/indicator/menu-builder.cpp (+6/-0)
src/indicator/menuitems/ethernet-item.cpp (+2/-2)
src/indicator/menuitems/ethernet-item.h (+1/-1)
src/indicator/menuitems/ethernet-link-item.cpp (+2/-2)
src/indicator/menuitems/ethernet-link-item.h (+1/-1)
src/indicator/sections/ethernet-link-section.cpp (+7/-4)
src/indicator/sections/ethernet-link-section.h (+1/-1)
src/indicator/sections/ethernet-section.cpp (+42/-16)
src/indicator/sections/ethernet-section.h (+1/-1)
tests/integration/indicator-network-test-base.cpp (+8/-0)
tests/integration/indicator-network-test-base.h (+2/-0)
tests/integration/test-indicator-phone.cpp (+20/-0)
To merge this branch: bzr merge lp://qastaging/~pete-woods/indicator-network/add-ethernet-settings-export
Reviewer Review Type Date Requested Status
dobey (community) Approve
unity-api-1-bot continuous-integration Approve
Review via email: mp+320340@code.qastaging.launchpad.net

Commit message

Add basic ethernet settings menu export

Description of the change

Add basic ethernet settings menu export

To post a comment you must log in.
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:672
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-network-ci/40/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1837
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1844
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1621/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1621/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1621/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1621/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1621/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1621
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1621/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-network-ci/40/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
dobey (dobey) wrote :

Approving as the code looks ok, but I'm not sure it makes too much sense on design level.

review: Approve
Reply

Unmerged revisions

672. By Pete Woods

Add basic ethernet settings menu export

671. By Pete Woods

Only physically export a single "phone" and tweak the indicator config file so it's used everywhere

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches