libdbusmenu-qt

Merge lp://qastaging/~pete-woods/libdbusmenu-qt/sync-mode-option into lp://qastaging/libdbusmenu-qt

  1. sync-mode-option
  2. Merge into trunk
Proposed by Pete Woods
Status: Merged
Approved by: Antti Kaijanmäki
Approved revision: 263
Merged at revision: 263
Proposed branch: lp://qastaging/~pete-woods/libdbusmenu-qt/sync-mode-option
Merge into: lp://qastaging/libdbusmenu-qt
Diff against target: 188 lines (+77/-37)
3 files modified
debian/changelog (+13/-0)
src/dbusmenuimporter.cpp (+48/-37)
src/dbusmenuimporter.h (+16/-0)
To merge this branch: bzr merge lp://qastaging/~pete-woods/libdbusmenu-qt/sync-mode-option
Reviewer Review Type Date Requested Status
Antti Kaijanmäki (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Marcus Tomlinson Pending
Review via email: mp+209445@code.qastaging.launchpad.net

Commit message

Add option to make DBus calls synchronous

Description of the change

* Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
  * Yes
 * Did you build your software in a clean sbuild/pbuilder chroot or ppa?
  * Yes
 * Did you build your software in a clean sbuild/pbuilder armhf chroot or ppa?
  * Yes
 * Has your component "TestPlan” been executed successfully on emulator, N4?
  * Yes
 * Has a 5 minute exploratory testing run been executed on N4?
  * Yes
 * If you changed the packaging (debian), did you subscribe a core-dev to this MP?
  * N/A
 * If you changed the UI, did you subscribe the design-reviewers to this MP?
  * No change
 * What components might get impacted by your changes?
  * Unity HUD
 * Have you requested review by the teams of these owning components?
  * Yes

Check List:
https://wiki.ubuntu.com/Process/Merges/Checklists/libdbusmenu-qt

Test Plan:
https://wiki.ubuntu.com/Process/Merges/TestPlan/libdbusmenu-qt

Silo:
https://launchpad.net/~ci-train-ppa-service/+archive/landing-002/

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:261
http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-ci/16/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-amd64-ci/11
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-armhf-ci/11
        deb: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-armhf-ci/11/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libdbusmenu-qt-ci/16/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:263
http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-ci/17/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-amd64-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/libdbusmenu-qt-trusty-armhf-ci/12/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libdbusmenu-qt-ci/17/rebuild

review: Approve (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM. Waiting for silo.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

 * Are any changes against your component pending/needed to land the MP under review in a functional state and are those called out explicitly by the submitter?
YES.

 * Did you do exploratory testing related to the component you own with the MP changeset included?
YES.

 * Has the submitter requested review by all the relevant teams/reviewres?
YES.

 * If you are the reviewer owning the component the MP is against, have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
YES.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: