Merge lp://qastaging/~pete-woods/storage-framework/cmake-extras-compatibility into lp://qastaging/storage-framework

Proposed by Pete Woods
Status: Rejected
Rejected by: Michi Henning
Proposed branch: lp://qastaging/~pete-woods/storage-framework/cmake-extras-compatibility
Merge into: lp://qastaging/storage-framework
Diff against target: 25 lines (+2/-2)
2 files modified
CMakeLists.txt (+1/-1)
debian/control.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~pete-woods/storage-framework/cmake-extras-compatibility
Reviewer Review Type Date Requested Status
Michi Henning (community) Disapprove
Review via email: mp+312724@code.qastaging.launchpad.net

Commit message

Compatibility with unversioned cmake-extras modules

Description of the change

Compatibility with unversioned cmake-extras modules

To post a comment you must log in.
Revision history for this message
Michi Henning (michihenning) wrote :

Works fine, thanks!

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

Rejecting this simply because we had problems with the silo. We've since merged the fix, so all is well.

review: Disapprove

Unmerged revisions

15. By Pete Woods

Compatibility with unversioned cmake-extras modules

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: