Merge lp://qastaging/~pete-woods/u1db-qt/transaction-around-schema-init into lp://qastaging/u1db-qt

Proposed by Pete Woods
Status: Merged
Approved by: Cris Dywan
Approved revision: 120
Merged at revision: 118
Proposed branch: lp://qastaging/~pete-woods/u1db-qt/transaction-around-schema-init
Merge into: lp://qastaging/u1db-qt
Diff against target: 93 lines (+47/-6)
1 file modified
src/database.cpp (+47/-6)
To merge this branch: bzr merge lp://qastaging/~pete-woods/u1db-qt/transaction-around-schema-init
Reviewer Review Type Date Requested Status
Cris Dywan Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+226221@code.qastaging.launchpad.net

Commit message

Improve database init performance by adding transactions

Description of the change

Improve database init performance by adding transactions

This branch takes the test time for unity-scopes-shell from >15s to ~2s.

To post a comment you must log in.
120. By Pete Woods

Formatting

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Cool stuff! I like the API, so simple.

review: Approve
Revision history for this message
Pete Woods (pete-woods) wrote :

Thanks! Should I propose a landing for this MR in the CI train? Or do you have a batch of other stuff lined up?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

In CI train now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: