Ubuntu Settings Components

Merge lp://qastaging/~pete-woods/ubuntu-settings-components/add-ethernet-item into lp://qastaging/ubuntu-settings-components

  1. add-ethernet-item
  2. Merge into trunk
Proposed by Pete Woods
Status: Rejected
Rejected by: Pete Woods
Proposed branch: lp://qastaging/~pete-woods/ubuntu-settings-components/add-ethernet-item
Merge into: lp://qastaging/ubuntu-settings-components
Diff against target: 264 lines (+225/-0)
5 files modified
debian/changelog (+6/-0)
plugins/Ubuntu/Settings/Menus/EthernetItem.qml (+85/-0)
plugins/Ubuntu/Settings/Menus/qmldir (+1/-0)
tests/qmltests/CMakeLists.txt (+1/-0)
tests/qmltests/Menus/tst_EthernetItem.qml (+132/-0)
To merge this branch: bzr merge lp://qastaging/~pete-woods/ubuntu-settings-components/add-ethernet-item
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Disapprove
Michał Sawicz Abstain
Unity8 CI Bot continuous-integration Approve
Review via email: mp+311503@code.qastaging.launchpad.net

Commit message

Add Menus.EthernetItem in support of indicator-network

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

N/A

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Tested on laptop. Phone/tablet devices don't have ethernet support.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

 * If you changed the UI, has there been a design review?

Yes, implementation was carried out with design team oversight.

 * If you changed localized strings, has the POT file been updated?

N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:173
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/114/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3375
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1936
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1936
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1936
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3403
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3253/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3253
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3253/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/114/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Please bump changelog here so you can depend on the new item.

review: Needs Fixing
lp://qastaging/~pete-woods/ubuntu-settings-components/add-ethernet-item updated
174. By Pete Woods

Dump debian version

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:174
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/115/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3386
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1946
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1946
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1946
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3414
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3265/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3265
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3265/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/115/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Thanks!

review: Abstain
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, but I think you can just reuse the BaseLayoutMenu with some "hacks".
And I'd avoid to send the triggered event when tapping on the item only.

So please, use this http://paste.ubuntu.com/23548192/ and you can just update the tests.
Also, please include an item in examples/OtherComponents.qml.

I'm also refactoring these components so that we don't have to use many typed items, but having a such checkable item that can be more generic.

Anyway it's fine for now... I was just wondering where's the design of the statusIcon item, as I didn't see it in the docs I've.

PS: if you'd need to add this to unity8, you also could add a breaks line to debian control to the bumped unity8 version, not to make autopkgtests angry on upgrade.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ah, if instead tapping in the item should toggle the switch, do the same we do in the SwitchMenu (or just rebase on that with something like http://paste.ubuntu.com/23548269/)

Revision history for this message
Pete Woods (pete-woods) wrote :

Hmm. You've managed to make this code so trivial that it seems pointless even adding this widget at all.

Revision history for this message
Pete Woods (pete-woods) wrote :

Especially as I got feedback from design to not include the icon any more.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ok, I think we can reject this then... Having more generic items is something I'd prefer to solve this kind of cases ;-).

review: Disapprove

Unmerged revisions

174. By Pete Woods

Dump debian version

173. By Pete Woods

Add EthernetItem widget

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: