Unity Action API

Merge lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action into lp://qastaging/unity-action-api

  1. automatic-quit-action
  2. Merge into trunk
Proposed by Pete Woods
Status: Merged
Approved by: Antti Kaijanmäki
Approved revision: 40
Merged at revision: 32
Proposed branch: lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action
Merge into: lp://qastaging/unity-action-api
Diff against target: 484 lines (+217/-24)
9 files modified
CMakeLists.txt (+5/-0)
debian/changelog (+7/-0)
include/unity/action/unity-action-manager.h (+2/-0)
qml/Ubuntu/Unity/Action/plugin.cpp (+7/-1)
src/CMakeLists.txt (+1/-1)
src/unity-action-manager.cpp (+59/-7)
test/cpp/tst_actionmanager.cpp (+14/-14)
test/qml/CMakeLists.txt (+14/-1)
test/qml/tst_api1.1.qml (+108/-0)
To merge this branch: bzr merge lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Antti Kaijanmäki (community) Approve
Review via email: mp+202653@code.qastaging.launchpad.net

Commit message

Add automatic quit action to HUD toolbar

Description of the change

Add automatic quit action to HUD toolbar

To post a comment you must log in.
lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action updated
34. By Pete Woods

Increment minor version number for QML action manager

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/unity-action-api-ci/46/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-amd64-ci/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-action-api-ci/46/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action updated
35. By Pete Woods

Add extra check target that prints the log on fail

36. By Pete Woods

Make the CPP tests pass

37. By Pete Woods

Make the QML tests pass

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:37
http://jenkins.qa.ubuntu.com/job/unity-action-api-ci/47/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-action-api-ci/47/rebuild

review: Approve (continuous-integration)
lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action updated
38. By Pete Woods

Handle global actions with specialisation

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/unity-action-api-ci/48/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-action-api-ci/48/rebuild

review: Approve (continuous-integration)
lp://qastaging/~pete-woods/unity-action-api/automatic-quit-action updated
39. By Pete Woods

Rename the _quit() signal to quit()

40. By Pete Woods

Missed the test case!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/unity-action-api-ci/49/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-action-api-ci/49/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

LGTM!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:40
http://jenkins.qa.ubuntu.com/job/unity-action-api-ci/50/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/unity-action-api-trusty-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-action-api-ci/50/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: