Merge lp://qastaging/~peter-pearse/ubuntu/natty/ncurses/prop001 into lp://qastaging/ubuntu/natty/ncurses

Proposed by Peter Pearse
Status: Work in progress
Proposed branch: lp://qastaging/~peter-pearse/ubuntu/natty/ncurses/prop001
Merge into: lp://qastaging/ubuntu/natty/ncurses
Diff against target: 56 lines (+37/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/10_cross.diff (+29/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://qastaging/~peter-pearse/ubuntu/natty/ncurses/prop001
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+51537@code.qastaging.launchpad.net

Description of the change

The test configure searches for the library containing certain functions e.g. tgoto.
As part of this it adds -L/lib. If a linker that fails on accessing incorrect binaries is used this causes the configuration to fail. One solution is to use a linker which does not fail on foreighn binaries. The correct solution is to ensure foreign binaries are not encountered.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

This seems to conflict with the upstream intent, however, which is that -L/lib is needed on certain Linux distributions. If it's no longer needed then that part should definitely be fixed upstream.

Is it sufficient to *prepend* the cross-compilation path? i.e., have both
    CF_ADD_LIBDIR(/usr/$ac_cv_host_alias/lib)
and
    CF_ADD_LIBDIR(/lib)
?

I also don't think we should be adding this path except in cases where we know we're cross-compiling; can you please fix this to be conditional on host != build?

review: Needs Fixing

Unmerged revisions

34. By Peter Pearse

When cross building, qualify the library search directory used for linux.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: