Merge lp://qastaging/~peter-petrakis/juju-deployer/devel-pyexpose into lp://qastaging/~gandelman-a/juju-deployer/trunk
Proposed by
Peter Petrakis
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~peter-petrakis/juju-deployer/devel-pyexpose |
| Merge into: | lp://qastaging/~gandelman-a/juju-deployer/trunk |
| Diff against target: |
60 lines (+13/-7) 3 files modified
configs/wiki.yaml (+3/-6) deployer/action/importer.py (+2/-1) deployer/env/py.py (+8/-0) |
| To merge this branch: | bzr merge lp://qastaging/~peter-petrakis/juju-deployer/devel-pyexpose |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kapil Thangavelu (community) | Approve | ||
| Adam Gandelman | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
- Implemented "expose" functionality
- Fixed configs/wiki.yaml, haproxy is exposed by default
To post a comment you must log in.
Unmerged revisions
- 74. By Peter Petrakis
-
Implement pyju expose
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Since the expose CLI interface is the same between py + go, can you instead add the expose functionality to env/base.py? Then we get it implemented for both environments.
Also:
50 + def expose(self, service_name, do_expose):
51 + params = self._named_
52 + params.
53 + if not do_expose:
54 + return
55 + self._check_call(
56 + params, self.log, "Error exposing service %s" % service_name)
The 'do_expose' parameter and check seem redundant since this is already being checked by the caller in importer.