Merge lp://qastaging/~peter.ahlgren/ubuntu/raring/obconf/fix-for-1179969 into lp://qastaging/ubuntu/raring/obconf

Proposed by Peter Ahlgren
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://qastaging/~peter.ahlgren/ubuntu/raring/obconf/fix-for-1179969
Merge into: lp://qastaging/ubuntu/raring/obconf
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
obconf.desktop (+1/-1)
To merge this branch: bzr merge lp://qastaging/~peter.ahlgren/ubuntu/raring/obconf/fix-for-1179969
Reviewer Review Type Date Requested Status
Dmitry Shachnev Needs Fixing
Ubuntu branches Pending
Review via email: mp+170065@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

* Please forward the fix upstream, I don't think we want to carry a delta (against Debian) because of such a minor fix.
* The source format is 3.0 (quilt), so you shouldn't change the upstream source directly, but via a patch instead. See http://developer.ubuntu.com/packaging/html/patches-to-packages.html for details.
* The version should be -1ubuntu1, not -1ubuntu2. Also, please target lp:ubuntu/obconf instead of lp:ubuntu/raring/obconf.
* Please remove empty line from the list of changes.

review: Needs Fixing

Unmerged revisions

7. By Peter Ahlgren

* obconf.desktop Changed Exec=obconf %f to Exec=obconf :LP #1179969
*

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: