Linaro Android Build Tools

Merge lp://qastaging/~pfalcon/linaro-android-build-tools/detailed-build-stats into lp://qastaging/linaro-android-build-tools

detailed-build-stats
Merge into trunk

Proposed by Paul Sokolovsky on 2012-02-14

Status:	Merged
Merged at revision:	412
Proposed branch:	lp://qastaging/~pfalcon/linaro-android-build-tools/detailed-build-stats
Merge into:	lp://qastaging/linaro-android-build-tools
Diff against target:	0 lines
To merge this branch:	bzr merge lp://qastaging/~pfalcon/linaro-android-build-tools/detailed-build-stats
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Georgy Redkozubov	2012-02-14	Approve on 2012-02-15
Linaro Infrastructure	2012-02-14	Pending
Review via email: mp+92945@code.qastaging.launchpad.net

Description of the change

This captures a tool used to collect data to produce graphs at https://wiki.linaro.org/Platform/Android/SeededBuilds#Benchmarks_and_Statistics .

Revision history for this message

Georgy Redkozubov (gesha) wrote on 2012-02-15:

Looks good.
Two things to mention.
1) By default 'time' command returns elapsed time in format of "minutes"m"seconds.milliseconds"s so you don't need to do a conversion to milliseconds for 'datetime.timedelta' parameter in parse_time_time function, just pass int(m.group(3))
2) Debug print command can be removed

review: Approve

Revision history for this message

Paul Sokolovsky (pfalcon) wrote on 2012-02-16:

1) I guess, you meant float() there. I just wasn't sure if timedelta() constructors accepts floats at all and if does proper normalization (vs just rounding). But it turns out that docs explicitly say yes to both, so simplified.
2) Fixed.

Thanks.

lp://qastaging/~pfalcon/linaro-android-build-tools/detailed-build-stats updated on 2012-02-16