Merge lp://qastaging/~pfalcon/linaro-android-build-tools/new-pub-staging into lp://qastaging/linaro-android-build-tools

Proposed by Paul Sokolovsky
Status: Merged
Approved by: Georgy Redkozubov
Approved revision: 596
Merged at revision: 597
Proposed branch: lp://qastaging/~pfalcon/linaro-android-build-tools/new-pub-staging
Merge into: lp://qastaging/linaro-android-build-tools
Diff against target: 89 lines (+22/-9)
2 files modified
utils/new-publish/propagate.py (+17/-8)
utils/new-publish/publish (+5/-1)
To merge this branch: bzr merge lp://qastaging/~pfalcon/linaro-android-build-tools/new-pub-staging
Reviewer Review Type Date Requested Status
Georgy Redkozubov Approve
James Tunnicliffe (community) Approve
Review via email: mp+159652@code.qastaging.launchpad.net

Description of the change

Add support to publish to staging with new publish interface. For consistency with existing script --staging (-s) option is used.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks good to me. Shame we don't have tests for this though.

review: Approve
Revision history for this message
Georgy Redkozubov (gesha) wrote :

+1

review: Approve
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, this codebase has only unit tests, not high-level tests for this stuff, and as it's just a prototype, doesn't make much sense to invest much into that (we already have projects with broken integration tests).

597. By Paul Sokolovsky

Unset option is None, not False.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches