Linaro Android Build Tools

Merge lp://qastaging/~pfalcon/linaro-android-build-tools/source-overlay into lp://qastaging/linaro-android-build-tools

source-overlay
Merge into trunk

Proposed by Paul Sokolovsky on 2011-12-15

Status:	Merged
Merged at revision:	384
Proposed branch:	lp://qastaging/~pfalcon/linaro-android-build-tools/source-overlay
Merge into:	lp://qastaging/linaro-android-build-tools
Diff against target:	32 lines (+14/-0) 2 files modified build-scripts/build-android (+4/-0) build-scripts/helpers (+10/-0)
To merge this branch:	bzr merge lp://qastaging/~pfalcon/linaro-android-build-tools/source-overlay
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Данило Шеган (community)	2011-12-15	Approve on 2011-12-15
James Tunnicliffe (community)	2011-12-15	Approve on 2011-12-15
Review via email: mp+85911@code.qastaging.launchpad.net

Description of the change

Support for SOURCE_OVERLAY build config var.

Revision history for this message

James Tunnicliffe (dooferlad) wrote on 2011-12-15:

With a change this small there can't possibly be any problems...
...well not that I can see.

review: Approve

Revision history for this message

Данило Шеган (danilo) wrote on 2011-12-15:

Is there something we could do to ensure nobody passes in a path with multiple "../.." in (or similar)?

Revision history for this message

Данило Шеган (danilo) wrote on 2011-12-15:

Paul tells me build authors can do whatever they want on the slave anyway, so not much use in guarding against this.

review: Approve

Revision history for this message

Paul Sokolovsky (pfalcon) wrote on 2011-12-15:

> Is there something we could do to ensure nobody passes in a path with multiple
> "../.." in (or similar)?

Currently, we just execute build config provided by user as a script - users can put any command there (which would be executed on a slave only, as non-root user, and logged to build log). So, doesn't buy as much, if to do something like that, then when we stabilize featureset and auditing all the code completely.