Linaro Android Frontend

Merge lp://qastaging/~pfalcon/linaro-android-frontend/http-downloads into lp://qastaging/linaro-android-frontend

  1. http-downloads
  2. Merge into trunk
Proposed by Paul Sokolovsky
Status: Merged
Merged at revision: 235
Proposed branch: lp://qastaging/~pfalcon/linaro-android-frontend/http-downloads
Merge into: lp://qastaging/linaro-android-frontend
Diff against target: 37 lines (+5/-3)
2 files modified
android_build/templates/buildDetails.html (+1/-1)
static/buildDetails.js (+4/-2)
To merge this branch: bzr merge lp://qastaging/~pfalcon/linaro-android-frontend/http-downloads
Reviewer Review Type Date Requested Status
Yongqin Liu (community) Approve
Michael Hudson-Doyle (community) Approve
Review via email: mp+80370@code.qastaging.launchpad.net

Description of the change

Use HTTP download links for artifacts in frontend, following introduction of HTTP downloads on android-build. Benefits: faster downloads, less system load, shorter links, no need for extra options to wget to workaround SSL cert issues.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Looks OK to me, but I haven't tested it at all.

review: Approve
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

Could you also modify post-build-lava.py to make the lava also use http to download?
I guess something like "build_url.replace('https', 'http')" would be ok.

review: Needs Fixing
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> Looks OK to me, but I haven't tested it at all.

I tested it on a sandbox.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

> Could you also modify post-build-lava.py to make the lava also use http to
> download?
> I guess something like "build_url.replace('https', 'http')" would be ok.

Yes, but that would be a separate patch ;-). Please feel free to provide one, or I will get to that some time later. And well, I wouldn't like to haste with changing all stuff immediately - for risk management, in case some issue with HTTP downloads will arise.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

OK, I see. Thanks.

for the post-build-lava.py one, i am thinking another modification for that file, maybe i can do that together.:)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches