Linaro Android Frontend

Merge lp://qastaging/~pfalcon/linaro-android-frontend/lava-requests-fixes into lp://qastaging/linaro-android-frontend

  1. lava-requests-fixes
  2. Merge into trunk
Proposed by Paul Sokolovsky
Status: Merged
Approved by: James Tunnicliffe
Approved revision: 245
Merged at revision: 244
Proposed branch: lp://qastaging/~pfalcon/linaro-android-frontend/lava-requests-fixes
Merge into: lp://qastaging/linaro-android-frontend
Diff against target: 81 lines (+24/-11)
2 files modified
android_build/frontend/api.py (+3/-1)
static/buildDetails.js (+21/-10)
To merge this branch: bzr merge lp://qastaging/~pfalcon/linaro-android-frontend/lava-requests-fixes
Reviewer Review Type Date Requested Status
James Tunnicliffe (community) Approve
Review via email: mp+88527@code.qastaging.launchpad.net

Description of the change

This unbreaks LAVA result display and makes sure we immediately have better clue in case any similar issue arise in the future.

To post a comment you must log in.
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Looks good.

Revision history for this message
James Tunnicliffe (dooferlad) :
review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Instead of using (typeof something == "undefined") you can use (something === undefined) (triple equality symbol). It's also interesting that you comment out the old-style URL attempts now: what happens with old builds that still have their artefacts on android-build?

Revision history for this message
Данило Шеган (danilo) wrote :

Actually, the above check for undefined won't work with variables directly, sorry.

Revision history for this message
James Tunnicliffe (dooferlad) wrote :

On 13 January 2012 16:43, Данило Шеган <email address hidden> wrote:
> Instead of using (typeof something == "undefined") you can use (something === undefined) (triple equality symbol).  It's also interesting that you comment out the old-style URL attempts now: what happens with old builds that still have their artefacts on android-build?

I was under the impression that we were dropping old builds, which was
why I OK'd the change!

--
James Tunnicliffe

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches