Linaro Image Tools

Merge lp://qastaging/~pfalcon/linaro-image-tools/snowball_dts_tweaks into lp://qastaging/linaro-image-tools/11.11

snowball_dts_tweaks
Merge into trunk

Proposed by Paul Sokolovsky on 2012-10-12

Status:

Merged

Approved by:

Milo Casagrande on 2012-10-17

Approved revision:

579

Merged at revision:

577

Proposed branch:

lp://qastaging/~pfalcon/linaro-image-tools/snowball_dts_tweaks

Merge into:

lp://qastaging/linaro-image-tools/11.11

Diff against target:

291 lines (+70/-22)

3 files modified

linaro_image_tools/media_create/android_boards.py (+6/-0)
linaro_image_tools/media_create/boards.py (+6/-2)
linaro_image_tools/media_create/tests/test_media_create.py (+58/-20)

To merge this branch:

bzr merge lp://qastaging/~pfalcon/linaro-image-tools/snowball_dts_tweaks

Critical

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Milo Casagrande (community)	2012-10-12	Approve on 2012-10-17
Patrik Ryd	2012-10-12	Pending
Mathieu Poirier	2012-10-12	Pending
Zach Pfeffer	2012-10-12	Pending
Review via email: mp+129419@code.qastaging.launchpad.net

Description of the change

This implements ability to override initrd_high and fdt_high params on the level of AndroidBoardConfig, per associated bug report. That bugreport however doesn't contain specific values to use for Snowball, so defaults are still used.

Revision history for this message

Patrik Ryd (patrik-ryd) wrote on 2012-10-15:

I guess we need different values for initrd_high and fdt_high for the stable_blob and the tracking_open build. I think we have to wait for a comment from Mathieu since he is the one that actually know all the details.

Revision history for this message

Milo Casagrande (milo) wrote on 2012-10-15:

Hi Paul,

apart from the default values to use, the changes look OK in order to add support for 'fdt_high' and 'initrd_high'.

There are though at least 20 tests failing with their introduction. Also, tests would need to be fixed with the correct values for the specific boards once we have them.

review: Needs Fixing

lp://qastaging/~pfalcon/linaro-image-tools/snowball_dts_tweaks updated on 2012-10-15

575. By Paul Sokolovsky on 2012-10-15: [merge] Merge form trunk.

Revision history for this message

Данило Шеган (danilo) wrote on 2012-10-16:

Mathieu emailed the following:

> This is what I have been working with:
>
> fdt_high=0x05000000
> initrd_high=0x06000000

lp://qastaging/~pfalcon/linaro-image-tools/snowball_dts_tweaks updated on 2012-10-16

576. By Paul Sokolovsky on 2012-10-16: Update tests for overridable values for 'initrd_high', 'fdt_high'.
577. By Paul Sokolovsky on 2012-10-16: Set actual values of fdt_high & initrd_high for Snowball, per Mathieu Poirier.

Revision history for this message

Paul Sokolovsky (pfalcon) wrote on 2012-10-16:

Fixed tests.

Added values as quoted above by Danilo.

This should be ready now.

Revision history for this message

Milo Casagrande (milo) wrote on 2012-10-17:

Hi Paul,

I still get 3 errors when running the tests.
One is PEP8 related:

./linaro_image_tools/media_create/android_boards.py:209:15: E221 multiple spaces before operator
./linaro_image_tools/media_create/android_boards.py:223:15: E221 multiple spaces before operator

The other two are related to the new values introduced. They are:

linaro_image_tools.media_create.tests.test_media_create.TestGetBootCmdAndroid.test_android_snowball_sd
linaro_image_tools.media_create.tests.test_media_create.TestGetBootCmdAndroid.test_android_snowball_emmc