camera-app

Merge lp://qastaging/~phablet-team/camera-app/photo-editor into lp://qastaging/camera-app

photo-editor
Merge into trunk

Proposed by Ugo Riboni on 2014-11-24

Status:

Merged

Approved by:

Bill Filler on 2015-02-05

Approved revision:

438

Merged at revision:

492

Proposed branch:

lp://qastaging/~phablet-team/camera-app/photo-editor

Merge into:

lp://qastaging/camera-app

Diff against target:

355 lines (+196/-9)

5 files modified

GalleryViewHeader.qml (+35/-5)
IconButton.qml (+3/-1)
SlideshowView.qml (+56/-3)
debian/control (+2/-0)
tests/autopilot/camera_app/tests/test_photo_editor.py (+100/-0)

To merge this branch:

bzr merge lp://qastaging/~phablet-team/camera-app/photo-editor

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Bill Filler (community)			Approve on 2015-02-05
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-01-28
Florian Boucault (community)		2014-11-24	Needs Fixing on 2014-12-09
Review via email: mp+242696@code.qastaging.launchpad.net

Commit message

Add photo editor feature using the component from ubuntu-ui-extras.

Description of the change

Add photo editor feature using the component from ubuntu-ui-extras.

You will need this branch for this to work: https://code.launchpad.net/~phablet-team/ubuntu-ui-extras/photo-editor/+merge/242695

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-24:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/315/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2014-11-25

432. By Ugo Riboni on 2014-11-25: Open the photo editor using the correct method

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-11-25:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/319/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Florian Boucault (fboucault) wrote on 2014-12-01:

Code looks good.

review: Approve (code)

Revision history for this message

Florian Boucault (fboucault) wrote on 2014-12-09:

There is now a conflict in GalleryViewHeader.qml due to the introduction of a multi selection mode.

review: Needs Fixing

Revision history for this message

Florian Boucault (fboucault) wrote on 2014-12-09:

potential conflict resolution at https://code.launchpad.net/~fboucault/camera-app/photo-editor

Revision history for this message

Florian Boucault (fboucault) wrote on 2014-12-09:

Another semantical conflict in SlideshowView.qml:

SharePopover from Ubuntu UI Extras is picked up instead of the local one causing the photo roll to not load at all.

review: Needs Fixing

Revision history for this message

Florian Boucault (fboucault) wrote on 2014-12-09:

When going in edit mode, the photo is not displayed at all, black instead.

review: Needs Fixing

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2014-12-09

433. By Ugo Riboni on 2014-12-09: Merge changes from trunk
434. By Ugo Riboni on 2014-12-09: Don't allow flicking back to the viewfinder while editing
435. By Ugo Riboni on 2014-12-09: Fix bug in the way actions are passed to the header

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-11:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/341/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2014-12-15

436. By Ugo Riboni on 2014-12-15: Merge changes from trunk

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-15:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/348/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2014-12-16

437. By Ugo Riboni on 2014-12-16: Add unit tests for making sure the photo editor appears and disappears correctly

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-12-16:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/349/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2015-01-28

438. By Ugo Riboni on 2015-01-28: Merge changes from trunk

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-28:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/373/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Bill Filler (bfiller) wrote on 2015-02-02:

Nice job Ugo! This works really well.
Couple of small issues I noticed:

1) Revert to Original button:
It's always in the disabled state on the toolbar, yet pressing it always shows the dialog even if there aren't any changes to the photo. It should become enabled only when there is an edit to revert and when it's disabled, pressing it should have no action.

2) The image enhancer action takes quite a while to finish. Currently it just shows a spinner on the image until it's complete. Would be better I think if we could add a message to the spinner with a message as to what is happening, as I wasn't even clear what the button did exactly. Something like "Auto-enhancing image..." or something like that.

3) Brightness: is there any way to update the image in real-time when changing the brightness rather than waiting until you release the slider?

review: Needs Fixing

Revision history for this message

Bill Filler (bfiller) wrote on 2015-02-05:

approved

review: Approve

lp://qastaging/~phablet-team/camera-app/photo-editor updated on 2015-02-11

439. By Ugo Riboni on 2015-02-03: Merge chnages from trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Ubuntu Phablet Team

deaunapaul