camera-app

Merge lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests into lp://qastaging/camera-app

refactor-and-fix-editor-tests
Merge into trunk

Proposed by Ugo Riboni on 2015-02-25

Status:	Merged
Approved by:	Florian Boucault on 2015-03-11
Approved revision:	537
Merged at revision:	534
Proposed branch:	lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests
Merge into:	lp://qastaging/camera-app
Diff against target:	479 lines (+171/-117) 7 files modified tests/autopilot/camera_app/data/__init__.py (+6/-0) tests/autopilot/camera_app/emulators/main_window.py (+4/-2) tests/autopilot/camera_app/emulators/panel.py (+4/-3) tests/autopilot/camera_app/tests/__init__.py (+30/-0) tests/autopilot/camera_app/tests/test_capture.py (+5/-2) tests/autopilot/camera_app/tests/test_gallery_view.py (+63/-73) tests/autopilot/camera_app/tests/test_photo_editor.py (+59/-37)
To merge this branch:	bzr merge lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Florian Boucault (community)		2015-02-25	Approve on 2015-03-11
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-03-10
Review via email: mp+250931@code.qastaging.launchpad.net

Commit message

Refactor camera editor tests, make them work even if UI extras are not installed, and add a test for the edit button being disabled when on a video

Description of the change

Refactor camera editor tests, make them work even if UI extras are not installed, and add a test for the edit button being disabled when on a video

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-25:

FAILED: Continuous integration, rev:526
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~phablet-team/camera-app/refactor-and-fix-editor-tests/+merge/250931/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/395/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests updated on 2015-02-26

527. By Ugo Riboni on 2015-02-26: Fix very random bug on dragging the panel by maximizing the speed of drag

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-26:

FAILED: Continuous integration, rev:527
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~phablet-team/camera-app/refactor-and-fix-editor-tests/+merge/250931/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/396/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-26:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/397/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests updated on 2015-03-09

528. By Ugo Riboni on 2015-03-09: Prevent failure when removing config file if it does not exist

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/403/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/404/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-09:

FAILED: Continuous integration, rev:527
http://jenkins.qa.ubuntu.com/job/camera-app-ci/405/
Executed test runs:
    None: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/101/console
    None: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/101/console
    None: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/101/console
    None: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/179/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/705/console
    None: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/431/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/823/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/405/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/406/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests updated on 2015-03-10

529. By Ugo Riboni on 2015-03-10: Merge lp:~canonical-platform-qa/camera-app/close-panel-helper-fix to group more fixes in one review
530. By Ugo Riboni on 2015-03-10: Explicit rate parameter in calls to drag

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/407/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/408/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/camera-app/refactor-and-fix-editor-tests updated on 2015-03-10

531. By Ugo Riboni on 2015-03-10: When possible prefer adding sample media in advance of launching the app than taking actual pictures or videos
532. By Ugo Riboni on 2015-03-10: Make sure we don't fail if for any reason there are subdirectories while we try to clean the media directory
533. By Ugo Riboni on 2015-03-10: Merge changes from trunk
534. By Ugo Riboni on 2015-03-10: Fix missing parameter on call
535. By Ugo Riboni on 2015-03-10: Minimize swipe speed when switching to gallery view and back as it seems to be necessary to fix the problem in combination with previous changes
536. By Ugo Riboni on 2015-03-10: Ensure environment is clean of other media when running tests