camera-app

Merge lp://qastaging/~phablet-team/camera-app/watch-refresh-thumbs into lp://qastaging/camera-app

  1. watch-refresh-thumbs
  2. Merge into trunk
Proposed by Ugo Riboni
Status: Merged
Approved by: Bill Filler
Approved revision: 483
Merged at revision: 493
Proposed branch: lp://qastaging/~phablet-team/camera-app/watch-refresh-thumbs
Merge into: lp://qastaging/camera-app
Diff against target: 30 lines (+8/-1)
2 files modified
CameraApp/foldersmodel.cpp (+5/-0)
PhotogridView.qml (+3/-1)
To merge this branch: bzr merge lp://qastaging/~phablet-team/camera-app/watch-refresh-thumbs
Reviewer Review Type Date Requested Status
Florian Boucault (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+247837@code.qastaging.launchpad.net

Commit message

Refresh properly the thumbnails when the picture is changed. Make sure after the first change the file is still being watched.

Description of the change

Refresh properly the thumbnails when the picture is changed. Make sure after the first change the file is still being watched.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:480
http://jenkins.qa.ubuntu.com/job/camera-app-ci/372/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/68/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/68/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/68/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/109
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/485/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/210
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17552
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/591/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/372/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:483
http://jenkins.qa.ubuntu.com/job/camera-app-ci/374/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-amd64-ci/70/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-armhf-ci/70/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/camera-app-vivid-i386-ci/70/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/111
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/489/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/750
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/212
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/17565
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/595/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/camera-app-ci/374/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Florian Boucault (fboucault) wrote :

"?at=" + Date.now() makes it so that the thumbnail is _always_ recomputed even though the file might not have changed.

review: Needs Fixing
Revision history for this message
Florian Boucault (fboucault) wrote :

> "?at=" + Date.now() makes it so that the thumbnail is _always_ recomputed even
> though the file might not have changed.

Not sure about that anymore, my brain is failing. Let's discuss it ASAP

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches