dialer-app

Merge lp://qastaging/~phablet-team/dialer-app/phone_settings into lp://qastaging/dialer-app/staging

  1. phone_settings
  2. Merge into staging
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 574
Merged at revision: 559
Proposed branch: lp://qastaging/~phablet-team/dialer-app/phone_settings
Merge into: lp://qastaging/dialer-app/staging
Prerequisite: lp://qastaging/~phablet-team/dialer-app/expand-dialer
Diff against target: 3554 lines (+2449/-153)
58 files modified
TODO (+1/-0)
debian/dialer-app.install (+1/-0)
po/dialer-app.pot (+253/-111)
src/qml/AccountsModel.qml (+1/-1)
src/qml/CMakeLists.txt (+1/-0)
src/qml/ContactsPage/ContactsPage.qml (+1/-1)
src/qml/ContactsPage/KeyboardRectagle.qml (+1/-1)
src/qml/DialerPage/CallButton.qml (+1/-1)
src/qml/DialerPage/CustomButton.qml (+1/-1)
src/qml/DialerPage/DialerBottomEdge.qml (+1/-1)
src/qml/DialerPage/DialerPage.qml (+12/-3)
src/qml/DialerPage/KeypadButton.qml (+1/-1)
src/qml/DialerPage/KeypadEntry.qml (+1/-1)
src/qml/Dialogs/DisableFlightModeDialog.qml (+1/-1)
src/qml/Dialogs/FlightModeProgressDialog.qml (+1/-1)
src/qml/Dialogs/NoDefaultSIMCardDialog.qml (+1/-1)
src/qml/Dialogs/NotificationDialog.qml (+1/-1)
src/qml/Dialogs/SetDefaultSIMCardDialog.qml (+1/-1)
src/qml/Dialogs/SimLockedDialog.qml (+1/-1)
src/qml/Dialogs/UssdErrorDialog.qml (+1/-1)
src/qml/Dialogs/UssdProgressDialog.qml (+1/-1)
src/qml/Dialogs/UssdResponseDialog.qml (+1/-1)
src/qml/HistoryPage/ExpandableButton.qml (+1/-1)
src/qml/HistoryPage/HistoryDelegate.qml (+1/-1)
src/qml/HistoryPage/HistoryDetailsPage.qml (+1/-1)
src/qml/HistoryPage/HistoryPage.qml (+1/-1)
src/qml/HistoryPage/SwipeItemDemo.qml (+1/-1)
src/qml/InputInfo.qml (+1/-1)
src/qml/LiveCallPage/ConferenceCallDisplay.qml (+1/-1)
src/qml/LiveCallPage/HangupButton.qml (+1/-1)
src/qml/LiveCallPage/LiveCall.qml (+12/-4)
src/qml/LiveCallPage/LiveCallKeypadButton.qml (+1/-1)
src/qml/LiveCallPage/MultiCallDisplay.qml (+1/-1)
src/qml/LiveCallPage/StopWatch.qml (+1/-1)
src/qml/MMI/IMEI.qml (+1/-1)
src/qml/MMI/IMEIDialog.qml (+1/-1)
src/qml/SettingsPage/AccountSettings/CMakeLists.txt (+6/-0)
src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml (+177/-0)
src/qml/SettingsPage/AccountSettings/sip.qml (+30/-0)
src/qml/SettingsPage/CMakeLists.txt (+8/-0)
src/qml/SettingsPage/CallForwardItem.qml (+240/-0)
src/qml/SettingsPage/CallForwarding.qml (+393/-0)
src/qml/SettingsPage/CallWaiting.qml (+108/-0)
src/qml/SettingsPage/KeyboardRectangle.qml (+77/-0)
src/qml/SettingsPage/MultiSim.qml (+113/-0)
src/qml/SettingsPage/NoSims.qml (+46/-0)
src/qml/SettingsPage/Ofono.qml (+69/-0)
src/qml/SettingsPage/OnlineAccountsHelper.qml (+96/-0)
src/qml/SettingsPage/ServiceInfo.qml (+133/-0)
src/qml/SettingsPage/Services.qml (+74/-0)
src/qml/SettingsPage/SettingsItemTitle.qml (+44/-0)
src/qml/SettingsPage/SettingsPage.qml (+158/-0)
src/qml/SettingsPage/SettingsTextField.qml (+29/-0)
src/qml/SettingsPage/SingleSim.qml (+69/-0)
src/qml/SettingsPage/VCardParser.qml (+55/-0)
src/qml/SettingsPage/callForwardingUtils.js (+126/-0)
src/qml/SettingsPage/dateUtils.js (+69/-0)
src/qml/dialer-app.qml (+19/-5)
To merge this branch: bzr merge lp://qastaging/~phablet-team/dialer-app/phone_settings
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+320669@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2017-01-12.

Commit message

Move the phone settings from ubuntu-system-settings to dialer-app.

Description of the change

Move the phone settings from ubuntu-system-settings to dialer-app.

To post a comment you must log in.
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote : Posted in a previous version of this proposal

Should we use the new ListItem to correct handle keyboard navigation and other theme related features?

Some small inline comments.

review: Needs Fixing
lp://qastaging/~phablet-team/dialer-app/phone_settings updated
572. By Gustavo Pichorim Boiko

Remove unused file.

573. By Gustavo Pichorim Boiko

Update to QtQuick 2.4

574. By Gustavo Pichorim Boiko

Add a TODO file with the pending items.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Regarding the ListItem usage, this code was imported from ubuntu-system-settings. There are more things to update in there, so this will be addressed in a separate MR. The other comments (that were placed in the diff of the previous version of this MR) were addressed.

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: