gallery-app

Merge lp://qastaging/~phablet-team/gallery-app/avoid-thumbnailers-from-viewer into lp://qastaging/gallery-app

avoid-thumbnailers-from-viewer
Merge into trunk

Proposed by Ugo Riboni on 2015-01-20

Status:

Merged

Approved by:

Arthur Mello on 2015-01-21

Approved revision:

1132

Merged at revision:

1130

Proposed branch:

lp://qastaging/~phablet-team/gallery-app/avoid-thumbnailers-from-viewer

Merge into:

lp://qastaging/gallery-app

Diff against target:

114 lines (+20/-23)

5 files modified

rc/qml/MediaViewer/MediaViewer.qml (+0/-5)
rc/qml/MediaViewer/SingleMediaViewer.qml (+1/-17)
src/medialoader/photo-metadata.cpp (+11/-0)
src/medialoader/photo-metadata.h (+5/-0)
src/photo/photo-edit-thread.cpp (+3/-1)

To merge this branch:

bzr merge lp://qastaging/~phablet-team/gallery-app/avoid-thumbnailers-from-viewer

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Arthur Mello (community)		2015-01-20	Approve on 2015-01-21
PS Jenkins bot	continuous-integration		Needs Fixing on 2015-01-20
Review via email: mp+246997@code.qastaging.launchpad.net

Commit message

Directly downscale the images for the viewer instead of asking the thumbnailer to do it (which it would do incorrectly)

Description of the change

Directly downscale the images for the viewer instead of asking the thumbnailer to do it (which it would do incorrectly)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-20:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1092/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/gallery-app/avoid-thumbnailers-from-viewer updated on 2015-01-20

1131. By Ugo Riboni on 2015-01-20: Use the post-edit reload mechanism built into the photo editor instead of manually doing it from qml

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-20:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1093/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~phablet-team/gallery-app/avoid-thumbnailers-from-viewer updated on 2015-01-20

1132. By Ugo Riboni on 2015-01-20: Save the exif thumbnail after editing the image

Revision history for this message

Arthur Mello (artmello) wrote on 2015-01-20:

I just tested this branch with r204. The issue related with opening pictures does not happen anymore. Rotation (with undo and back to original) seems to work as expected.

But I think there are some issues with crop:
- On a first crop on an image, when we return to the picture we can still see the original image on the background with the loading spin until the cropped image is loaded. Besides that the first crop works;
- On subsequent crops on the same image there are some strange behaviors. The image displayed is the original one and not the result of the previous crop. The blue rectangle does not always have the size of the previous crop over the original image, on some cases it was smaller than the previously cropped area. Sometimes I was able to increase the cropped area over the previous one but sometimes that was not possible. Besides that, the results of the cropped area seems ok and the thumbnail seems to be updated as expected.

review: Needs Fixing

Revision history for this message

Arthur Mello (artmello) wrote on 2015-01-20:

Ok, so I tested the current trunk version of gallery on the same image release and the crop issues are all there. It does not seem to be introduced by this MR.

But I was not able to reproduce the original image on the background with the loading spin while the result of a crop is generated. Not sure if that is a desired behavior.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-20:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1094/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Ugo Riboni (uriboni) wrote on 2015-01-21:

The crop issues (for crops after the first) are long standing.
They have been fixed in the external photo editor, which uses a different logic for crop entirely.
I would not bother with them and work on pushing the new editor ASAP after RTM

Revision history for this message

Arthur Mello (artmello) wrote on 2015-01-21:

Since neither of the issues are regression this MR does fix the problem and the code lgtm.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Ubuntu Phablet Team