Merge lp://qastaging/~phablet-team/network-manager/lp1445080-wily into lp://qastaging/~network-manager/network-manager/ubuntu
Proposed by
Tony Espy
Status: | Merged |
---|---|
Approved by: | Mathieu Trudel-Lapierre |
Approved revision: | 970 |
Merged at revision: | 969 |
Proposed branch: | lp://qastaging/~phablet-team/network-manager/lp1445080-wily |
Merge into: | lp://qastaging/~network-manager/network-manager/ubuntu |
Prerequisite: | lp://qastaging/~phablet-team/network-manager/lp1461593-wily |
Diff against target: |
762 lines (+301/-188) 6 files modified
debian/changelog (+7/-0) debian/patches/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch (+215/-183) debian/patches/lp1445080-modify-device-modem-avail.patch (+44/-0) debian/patches/lp1445080-nm-modem-check-for-set-mm-enabled-func.patch (+28/-0) debian/patches/lp1461593-add-modem-reconnect-delay-to-policy.patch (+5/-5) debian/patches/series (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~phablet-team/network-manager/lp1445080-wily |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Approve | ||
Review via email: mp+264895@code.qastaging.launchpad.net |
Description of the change
This change re-factors the modem_state handling code in NMModemOfono to solve underlying race conditions in the handling of flight-mode.
To post a comment you must log in.
Have the code bits been discussed with upstream? What is the likely impact on non-ofono modems of the changes to nm_device_modem to not return that connections are unavailable when the modem is still in NM_MODEM_ STATE_INITIALIZ ING state, for example?
As per the other patches, I think the ofono code changes should be merged in to the main patch for the modem support (since we're at a development release, this makes it just one large patch to fixup when there is a need to refresh the patch, rather than conflicting, interdepending change sets), and any core changes should be in a separate, isolated patch so that we can send them upstream ASAP.
Since I don't know whether there has been careful testing of the impact of the NMDeviceModem changes on non-ofono modem -> Needs Information.