Merge lp://qastaging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid into lp://qastaging/~phablet-team/network-manager/vivid-phone-overlay
| Status: | Merged |
|---|---|
| Approved by: | Alfonso Sanchez-Beato |
| Approved revision: | 969 |
| Merged at revision: | 969 |
| Proposed branch: | lp://qastaging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid |
| Merge into: | lp://qastaging/~phablet-team/network-manager/vivid-phone-overlay |
| Diff against target: |
192 lines (+115/-30) 2 files modified
debian/changelog (+8/-0) debian/patches/0002-wifi-cull-the-scan-list-before-signalling-ScanDone-b.patch (+107/-30) |
| To merge this branch: | bzr merge lp://qastaging/~phablet-team/network-manager/lp1480877-wifi-rm-dup-scan-signals-vivid |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mathieu Trudel-Lapierre | Approve | ||
| Simon Fels | Pending | ||
|
Review via email:
|
|||
Description of the change
This change fixes a problem where duplicate (2-3x) AccessPoint 'LastSeen' PropertiesChanged signals are generated each time a WiFi scan completes. This can be seen by running:
dbus-monitor --system --profile "type='
...and waiting for a scan to occur. You'll see 2-3 PropsChanged for each AccessPoint after a scan. From then on, you'll only see changes for AccessPoint/0 until the next scan happens.
The change makes cull_scan_list the function responsible for updating an AP's last-seen property, and ensures that scan_done_cb is the only function that calls cull_scan_list. It also removes the bss_updated_cb function, as its only purpose was to update the last-seen property and schedule yet another scanlist cull.
| Mathieu Trudel-Lapierre (cyphermox) | # |
