Merge lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n into lp://qastaging/notes-app

Proposed by Ugo Riboni
Status: Approved
Approved by: Olivier Tilloy
Approved revision: 293
Proposed branch: lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n
Merge into: lp://qastaging/notes-app
Diff against target: 197 lines (+44/-53)
6 files modified
.bzrignore (+3/-0)
CMakeLists.txt (+15/-18)
NotesApp.qmlproject (+0/-25)
notes-app.desktop.in.in (+4/-3)
po/CMakeLists.txt (+15/-4)
po/com.ubuntu.notes.pot (+7/-3)
To merge this branch: bzr merge lp://qastaging/~phablet-team/notes-app/inline-desktop-i18n
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Needs Fixing
David Planella (community) Approve
Review via email: mp+235785@code.qastaging.launchpad.net

Description of the change

Update the desktop file for inline i18n

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Looks good to me at a glance. Just one inline comment.

review: Needs Fixing
293. By Ugo Riboni

Remove a duplicate line and a line that is unnecessary

Revision history for this message
David Planella (dpm) wrote :

LGTM, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM.

review: Approve

Unmerged revisions

293. By Ugo Riboni

Remove a duplicate line and a line that is unnecessary

292. By Ugo Riboni

Show all source when loading the cmake project, and remove the qmlproject file which serves no purpose any more

291. By Ugo Riboni

Update the pot file

290. By Ugo Riboni

Generate inline desktop translations

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: