qtubuntu-media

Merge lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes into lp://qastaging/qtubuntu-media/stable

  1. bg-playlist-fixes
  2. Merge into stable
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 97
Merged at revision: 90
Proposed branch: lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes
Merge into: lp://qastaging/qtubuntu-media/stable
Diff against target: 615 lines (+293/-33)
8 files modified
src/aal/aalmediaplayercontrol.cpp (+20/-11)
src/aal/aalmediaplayerservice.cpp (+5/-6)
src/aal/aalmediaplaylistcontrol.cpp (+19/-1)
src/aal/aalmediaplaylistcontrol.h (+2/-0)
src/aal/aalmediaplaylistprovider.cpp (+107/-13)
src/aal/aalmediaplaylistprovider.h (+9/-0)
tests/integration/tst_mediaplaylist.cpp (+126/-2)
tests/integration/tst_mediaplaylist.h (+5/-0)
To merge this branch: bzr merge lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
Review via email: mp+276164@code.qastaging.launchpad.net

Commit message

Emit onPlaybackModeChanged (LP: #1510219).
Implements insertTrack() so that a client can move a track into a new position by first calling removeTrack().
Do proper clean-up when switching between playlist and playing a single
URI (LP: #1511029).

Description of the change

Emit onPlaybackModeChanged (LP: #1510219).
Implements insertTrack() so that a client can move a track into a new position by first calling removeTrack().
Do proper clean-up when switching between playlist and playing a single
URI (LP: #1511029).

To post a comment you must log in.
lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes updated
92. By Alfonso Sanchez-Beato

Do proper clean-up when switching between playlist and playing a single
URI (LP: #1511029)

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good for the parts that you contributed Alfonso. We won't top approve this until we get all of the qtubuntu-media fixes into this branch and better tested together.

review: Approve (code)
lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes updated
93. By Alfonso Sanchez-Beato

Fix double connections to events and avoid some unnecessay DBus calls.

94. By Alfonso Sanchez-Beato

Revert change that caused forward button not to work

95. By Alfonso Sanchez-Beato

Add support for TrackListReset signal, which is now emitted instead of
one TrackRemoved per track when we call media-hub's Reset DBus call.

96. By Alfonso Sanchez-Beato

Update current track index after performing operations that alter the
track list.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

A few comments inline below.

review: Needs Fixing (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Will address comments asap. Please see also comment below.

lp://qastaging/~phablet-team/qtubuntu-media/bg-playlist-fixes updated
97. By Alfonso Sanchez-Beato

Address review comments

Revision history for this message
Jim Hodapp (jhodapp) :
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: