Merge lp://qastaging/~phablet-team/qtubuntu-media/fix-1506953 into lp://qastaging/qtubuntu-media

Proposed by Jim Hodapp
Status: Merged
Approved by: Konrad Zapałowicz
Approved revision: 114
Merged at revision: 111
Proposed branch: lp://qastaging/~phablet-team/qtubuntu-media/fix-1506953
Merge into: lp://qastaging/qtubuntu-media
Diff against target: 438 lines (+164/-34)
8 files modified
debian/control (+1/-1)
src/aal/aalmediaplayerservice.cpp (+79/-8)
src/aal/aalmediaplayerservice.h (+4/-1)
src/aal/aalmediaplaylistcontrol.cpp (+55/-19)
src/aal/aalmediaplaylistprovider.cpp (+2/-4)
src/aal/aalvideorenderercontrol.cpp (+8/-1)
tests/unit/service.cpp (+12/-0)
tests/unit/service.h (+3/-0)
To merge this branch: bzr merge lp://qastaging/~phablet-team/qtubuntu-media/fix-1506953
Reviewer Review Type Date Requested Status
Konrad Zapałowicz (community) code Approve
Review via email: mp+300533@code.qastaging.launchpad.net

Commit message

Register for media-hub service unregister/register signals and raise an error to the client application when media-hub-server unregisters and then re-registers on dbus. This will allow the client to handle this event as it deems appropriate.

Description of the change

Register for media-hub service unregister/register signals and raise an error to the client application when media-hub-server unregisters and then re-registers on dbus. This will allow the client to handle this event as it deems appropriate.

To post a comment you must log in.
112. By Jim Hodapp

Merge with upstream

113. By Jim Hodapp

Clean up unnecessary debug statements

114. By Jim Hodapp

Another unnessary debug statement

Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

LGTM

review: Approve (code)
115. By Jim Hodapp

Some additional protection from unhandled exceptions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: