Merge lp://qastaging/~phablet-team/telepathy-ofono/generate-ids-for-room-channels into lp://qastaging/telepathy-ofono/staging

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 183
Merged at revision: 182
Proposed branch: lp://qastaging/~phablet-team/telepathy-ofono/generate-ids-for-room-channels
Merge into: lp://qastaging/telepathy-ofono/staging
Diff against target: 81 lines (+28/-10)
1 file modified
connection.cpp (+28/-10)
To merge this branch: bzr merge lp://qastaging/~phablet-team/telepathy-ofono/generate-ids-for-room-channels
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+310357@code.qastaging.launchpad.net

Commit message

Generate Ids for non existing room channels and fill participants based on targetId when provided.

Description of the change

Generate Ids for non existing room channels and fill participants based on targetId when provided.

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Just one small request, looks good otherwise.

review: Needs Fixing
183. By Tiago Salem Herrmann

Also check if targetId does not start with mms:

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: