Merge lp://qastaging/~phablet-team/telephony-service/add-participants-model into lp://qastaging/telephony-service/staging

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1250
Merged at revision: 1247
Proposed branch: lp://qastaging/~phablet-team/telephony-service/add-participants-model
Merge into: lp://qastaging/telephony-service/staging
Prerequisite: lp://qastaging/~phablet-team/telephony-service/multiple_performance_improvements1
Diff against target: 595 lines (+387/-12)
9 files modified
Ubuntu/Telephony/CMakeLists.txt (+1/-0)
Ubuntu/Telephony/components.cpp (+2/-0)
Ubuntu/Telephony/participantsmodel.cpp (+233/-0)
Ubuntu/Telephony/participantsmodel.h (+92/-0)
handler/texthandler.cpp (+6/-0)
libtelephonyservice/chatentry.cpp (+21/-8)
libtelephonyservice/chatentry.h (+8/-1)
libtelephonyservice/participant.cpp (+13/-2)
libtelephonyservice/participant.h (+11/-1)
To merge this branch: bzr merge lp://qastaging/~phablet-team/telephony-service/add-participants-model
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+317390@code.qastaging.launchpad.net

Commit message

Add ParticipantsModel

Description of the change

Add ParticipantsModel

To post a comment you must log in.
1241. By Tiago Salem Herrmann

Add missing files

1242. By Tiago Salem Herrmann

add missing cpp file

1243. By Tiago Salem Herrmann

add more props to participants

1244. By Tiago Salem Herrmann

include all participants

1245. By Tiago Salem Herrmann

change string comparison method

1246. By Tiago Salem Herrmann

fallback to threadId if no participant is provided

1247. By Tiago Salem Herrmann

merge parent

1248. By Tiago Salem Herrmann

Fix sorting

1249. By Tiago Salem Herrmann

merge parent branch

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Some things need to be addressed, but in general it looks good.

review: Needs Fixing
1250. By Tiago Salem Herrmann

use enums instead of uints and disconnect old instances of ChatEntry from the model

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

done

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: