Code review comment for lp://qastaging/~phablet-team/telephony-service/online-account-match

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> I think the correct solution for this would be to use the addressableFields
> each account provides, but for now this implementation will do.
>
> Can you just add an entry to the TODO list saying that maybe the X-IRC match
> should be done by providing the correct vcard fields in the messaging-
> framework plugin?

I am not sure if I understand what do you expect from "addressableFields". The contacts are not stored as Vcards and some fields does not have 1 to 1 relationship with the QContactFields, some kind of translation is inevitable.

« Back to merge proposal