Code review comment for lp://qastaging/~phablet-team/telephony-service/online-account-match
Revision history for this message
| Gustavo Pichorim Boiko (boiko) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
dbe715f
demo site
(Get the code!)
> > I think the correct solution for this would be to use the addressableFields
> > each account provides, but for now this implementation will do.
> >
> > Can you just add an entry to the TODO list saying that maybe the X-IRC match
> > should be done by providing the correct vcard fields in the messaging-
> > framework plugin?
>
> I am not sure if I understand what do you expect from "addressableFie
> contacts are not stored as Vcards and some fields does not have 1 to 1
> relationship with the QContactFields, some kind of translation is inevitable.
For the IRC case, I would expect the addressableFields reported by the connection to contain the value "x-irc", and then use that to generate the contact filters. Doing a translation is fine, as long as we use the fields that the account reports as the reference for that.