Merge lp://qastaging/~phablet-team/telephony-service/qml-start-chat into lp://qastaging/telephony-service/staging

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 1247
Merged at revision: 1249
Proposed branch: lp://qastaging/~phablet-team/telephony-service/qml-start-chat
Merge into: lp://qastaging/telephony-service/staging
Prerequisite: lp://qastaging/~phablet-team/telephony-service/add-participants-model
Diff against target: 112 lines (+24/-2)
5 files modified
libtelephonyservice/accountentry.cpp (+8/-0)
libtelephonyservice/accountentry.h (+4/-0)
libtelephonyservice/accountlist.cpp (+9/-1)
libtelephonyservice/accountlist.h (+2/-0)
libtelephonyservice/chatmanager.h (+1/-1)
To merge this branch: bzr merge lp://qastaging/~phablet-team/telephony-service/qml-start-chat
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+317494@code.qastaging.launchpad.net

Commit message

Export startChat to QML.

To post a comment you must log in.
1244. By Renato Araujo Oliveira Filho

Notify individual accounts active change.

1245. By Tiago Salem Herrmann

merge parent branch

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Just one request.

review: Needs Fixing
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

> Just one request.
Fixed

1246. By Renato Araujo Oliveira Filho

Renamed activeAccountsChangedImpl function to match with the code style.

1247. By Renato Araujo Oliveira Filho

Rename missing function.

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: